Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Do not set user ID for container processes when using Podman #8

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

pothos
Copy link
Member

@pothos pothos commented Nov 6, 2020

With Podman the container root user is mapped to the user that starts
the container. This means the file permissions are already correct and
using a different user inside the container results in missing file
permissions.
Only set the user ID for Docker, not when Podman is used through a
"docker" wrapper script.

How to use/testing done

make/make test

With Podman the container root user is mapped to the user that starts
the container. This means the file permissions are already correct and
using a different user inside the container results in missing file
permissions.
Only set the user ID for Docker, not when Podman is used through a
"docker" wrapper script.
@pothos pothos requested review from vbatts and a team November 6, 2020 03:18
Copy link
Member

@vbatts vbatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbatts vbatts merged commit 3e0a70e into flatcar-master Nov 6, 2020
@vbatts vbatts deleted the kai/makefile-podman branch November 6, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants