Rust: Bump deps & 2021 edition, reexports, clippy #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nyurik
commented
Aug 9, 2023
nyurik
commented
- Re-export the entire geozero because it has a number of other used traits like Error, so reexporting partial geozero creates more problem than solves
- Switch all crates to 2021 edition
- Cleanup crate.toml - we may want to switch to a proper workspace here
- bump all dependency versions to latest
- Address some clippy warnings
* Re-export the entire geozero because it has a number of other used traits like Error, so reexporting partial geozero creates more problem than solves * Switch all crates to 2021 edition * Cleanup crate.toml - we may want to switch to a proper workspace here * bump all dependency versions to latest * Address some clippy warnings
``` cargo clippy --fix cargo clippy --workspace --allow-dirty --fix --benches --tests --bins -- -A clippy::all -W clippy::uninlined_format_args ```
* rename internal `to_feature` because it breaks Rust naming expectations * add a safety docs to `FgbReader::open_unchecked` -- please doublecheck that it is correct * fix a lot of `.write(...)` to `write_all(...)` - because write does not guarantee how many bytes it will write * removed a few lifetimes - clippy thinks they are not needed * `&Vec<_>` -> `&[_]` * Optimized `PackedRTree::build` iter
|
cc: @pka |
|
All good for me, many great improvements! |
|
thx @pka and @bjornharrtell , feel free to merge and release. I plan a release for geozero with some breaking changes, so the next release beyond these changes may have to be coordinated later too 🤦 |
bjornharrtell
approved these changes
Aug 11, 2023
|
@nyurik do you agree this should be squash merged? |
|
Sure, I always squash merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.