feat: Overloaded types for serialize() #341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lost some time
deserialize()
accepts a filter rectangle.Typescript overloading allows us to ensure return value types match input types, and looks like typedocs also generates separate entry for each overload.
https://www.tutorialsteacher.com/typescript/function-overloading
Only supporting rect for http range requests seems like an unnecessary restriction, why not implement the filtering for all variants (even if we parse the library could avoiding calling callbacks for features outside an area of interest)