Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic checkers loading #350

Merged
merged 5 commits into from
Feb 14, 2023
Merged

Dynamic checkers loading #350

merged 5 commits into from
Feb 14, 2023

Conversation

gasinvein
Copy link
Collaborator

@gasinvein gasinvein commented Feb 8, 2023 •
edited

  • Make checker classes self-register, so that they don't need to be listed explicitly
  • Skip checkers that failed to load due to an ImportError
    • This allows running f-e-d-c on non-Linux OSes natively

Fixes #349

@gasinvein gasinvein force-pushed the dynamic-checkers-load branch 2 times, most recently from 4be32b0 to 4b7fc8c Compare February 8, 2023 18:18
@coveralls
Copy link

coveralls commented Feb 8, 2023 •
edited

Coverage Status

Coverage: 92.328% (-0.1%) from 92.443% when pulling c05d65a on dynamic-checkers-load into 60d0c3b on master.

@gasinvein gasinvein requested a review from wjt February 8, 2023 19:15
@wjt wjt merged commit 59af8dd into master Feb 14, 2023
@wjt wjt deleted the dynamic-checkers-load branch February 14, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjt wjt wjt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make checkers optional
3 participants
@gasinvein @coveralls @wjt