Drop notifications talk-name

[bbhtt]

Electron 23.08 baseapp comes with libnotify 0.8 which uses the portal to show notifications

https://gitlab.gnome.org/GNOME/libnotify/-/blob/69aff6e5fa2842e00b409c348bd73188548828b3/NEWS#L25

[flathubbot]

Started test build 69310

[flathubbot]

Build 69310 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/51965/chat.rocket.RocketChat.flatpakref

[flathubbot]

Started test build 69379

[flathubbot]

Build 69379 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/52033/chat.rocket.RocketChat.flatpakref

[bbhtt]

Note, if the runtime update is reverted #116 then this needs to be reverted also

[andrevmatos]

@bbhtt can you reproduce the issue there on the new runtime with your patch here?

[bbhtt]

@bbhtt can you reproduce the issue there on the new runtime with your patch here?

Sorry I'm not a user of this app. I tried creating an account to test, but looks like the verification mail isn't working. It asks me to verify again if I click the link in mail and log in.

Is there some other way to trigger a notification in the app?

[andrevmatos]

One way I found out to trigger a notification is to open View > Open DevTools, then call from DevTool's Console:

let n = new Notification("test notification", { body: "Notification body" })

Not sure if this could trigger the bug if it happens above the stack though.

[bbhtt]

One way I found out to trigger a notification is to open View > Open DevTools, then call from DevTool's Console:

Thanks, that seems to work fine, I don't see any crash.

[geekgonecrazy]

Great thanks for also opening this fix. I wasn't able to test the previous PR I was mentioned in yesterday. But updated to this and also don't see crashes. 🙏

[geekgonecrazy]

Seems I was over optimistic or the commit wasn't yet downloaded.

sudo flatpak update --commit=d9f7d7691360809521895f20f6164705150054957f64df411868a9f66e527acc chat.rocket.RocketChat

This commit is the only way I can get anything done with out busy mode on to suppress notifications. Perfect level of annoying to be mid way through typing something and have it crash. 🙈

[bbhtt]

Fwiw, the crash mentioned here could be https://gitlab.gnome.org/GNOME/libnotify/-/issues/34 if it is in libnotify (check the backtrace in coredumpctl). Happens only when clicking the popup on GNOME shell.

This is due to some bug libnotify 0.8 which came from the runtime update and affects a bunch of electron apps.

[geekgonecrazy]

In my case i'm on i3wm and definitely don't actually click it. But definitely could be the same bug

[bbhtt]

In my case i'm on i3wm and definitely don't actually click it. But definitely could be the same bug

Can you get a backtrace and open an issue here, please? Follow https://www.figuiere.net/technotes/notes/tn001/

You'll need to flatpak install the following from flathub:

org.freedesktop.Sdk//23.08
org.freedesktop.Sdk.Debug//23.08
chat.rocket.RocketChat.Debug
org.electronjs.Electron2.BaseApp.Debug//23.08

The first two will be around 3-4 GB so have free space.

Then from coredumpctl list get the PID of the crash, run flatpak-coredumpctl -m PID chat.rocket.RocketChat, then enter bt at the (gdb) prompt.

[geekgonecrazy]

#121 created issue here