Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build since upgrade to webpack 4 #9

Closed
ghisvail opened this issue Dec 13, 2018 · 10 comments
Closed

Fails to build since upgrade to webpack 4 #9

ghisvail opened this issue Dec 13, 2018 · 10 comments

Comments

@ghisvail
Copy link
Collaborator

See the following comment

@x80486
Copy link

x80486 commented Dec 22, 2018

For the time being, I would consider switching to the .deb approach, as many other Electron-based Flatpak manifests.

@ghisvail
Copy link
Collaborator Author

ghisvail commented Jan 25, 2019 via email

@x80486
Copy link

x80486 commented Jan 31, 2019

Yeah, but I can't use any of that. Do you want me to update the manifest to start using the .deb approach. Wire works in the same way, and generally that's accepted in Flathub if there are/were issues building the application the way it's done right now. You can keep the work as it is in a different branch and test from time to time...that's what I do for Wire, and still unsuccessful, so I keep using the .deb files for the time being.

Let me know...

@ghisvail
Copy link
Collaborator Author

ghisvail commented Jan 31, 2019 via email

@kspearrin
Copy link

@x80486

For the time being, I would consider switching to the .deb approach, as many other Electron-based Flatpak manifests.

Do you have an example that can be referenced?

@x80486
Copy link

x80486 commented Mar 15, 2019

@kspearrin, you can take a look at Wire's manifest, or this pull request I sent a while back. I'm also trying to see if it can be built like this one.

@kspearrin
Copy link

@x80486

Why was your PR closed for the deb switch?

@x80486
Copy link

x80486 commented Mar 16, 2019

I closed it in favor of building it from sources via YARN, as Filippe did with OpenDrive...will try to send a pull request any time soon once I find some time.

@barthalion
Copy link
Member

Any news? Personally, I wouldn't mind if we switched to x86_64-only deb repackaging for now.

@ghisvail
Copy link
Collaborator Author

@barthalion I'll look into it. I am also in favor of switching to the repackaging in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants