-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set wayland flags when appropiate #248
Conversation
Started test build 6177 |
Build 6177 successful
|
Discord uses Electron 13. We'll have to wait. Also, disabling WebRTCPipeWireCapturer since they use their own thing (and it's obviously broken on Linux). |
you might want to move this to discord canary which uses electron 17 atm. |
Started test build 12845 |
Build 12845 successful
|
Started test build 12849 |
Build 12849 successful
|
Started test build 12850 |
- `WebRTCPipeWireCapturer`: use Pipewire to stream - `WaylandWindowDecorations`: show CSD (available since [electron17](electron/electron#29618)) - `--ozone-platform-hint=auto`: enable Wayland when possible Since some flags depend on the Electron version and I don't know which version Discord bundles, this might require waiting.
Discord uses its custom thing that prevents this from working.
Build 12850 successful
|
Started test build 12852 |
Build 12852 successful
|
Since this is using a script to start Discord anyway, I recommend setting Also, I think WaylandWindowDecorations can be passed unconditionally? |
So the latest discord does work under wayland, but it has no window decorations. Until that is fixed upstream I don't think this should be done. |
it's been fixed upstream for a while, just need discord to update electron again |
Not necessary, window decorations can be enabled by passing
Apart from screen sharing (which is now completely broken, previously it still worked for specific Xwayland windows), Discord is fully functional on Wayland natively for me with the flags in this PR now (however, |
Oh I missed that. So I tested it again after the 0.0.24 update and now Wayland no longer works here...
EDIT: Can confirm this is a regression: |
I've just realized that 0.0.24 is back on Electron 13.x. So, they were at 13.x with 0.0.22, upgraded to Electron 17.x with 0.0.23 then went back to Electron 13.x. This is why this regression happened. What a depressing thing to realize. |
hopefully electron 17 will be back with 0.0.25 |
0.0.25 still seems to be on Electron 13:
|
0.0.26 is on 22, screensharing is broken though (Wayland). Probably should wait for them to fix that, or figure something out here. |
Screensharing will remain broken unless Discord updates their native screen-sharing module, I don't see a way around that unless Discord provides a flag to disable their native screen-sharing entirely. It's already half-broken since it can only share other Xwayland apps, so the merit of delaying this PR for screen-sharing support is debatable. I can see some people might complain about it, I guess? |
you can use the xwayland video bridge to work around this for now |
I believe it is a valid downside to some users. We could start with a solution that lets users pick which they want, like an env var to opt-in or out. |
Started test build 37738 |
Build 37738 failed |
Replaced by #288. The main difference is just some documentation and |
-WebRTCPipeWireCapturer
: use Pipewire to streamWaylandWindowDecorations
: show CSD (available since electron17)--ozone-platform-hint=auto
: enable Wayland when possible (available since electron 18)Since some flags depend on the Electron version and I don't know which version Discord bundles, this might require waiting.