Didn't catch on v135.1 and v135.2

[TobTobXX]

• v135.1 came out 5 days ago
• v135.2 came out 3 days ago

somehow the data checker didn't catch on to these tags?

[muelli]

maybe because of the dot.
here's the regex:

com.github.Anuken.Mindustry/com.github.Anuken.Mindustry.yml

Line 59 in 0bb34e2

tag-pattern: "^v([\\d.]+)$"

[TobTobXX]

EDIT: Nope, that's actually not the regex in use. Look at the beta branch:

com.github.Anuken.Mindustry/com.github.Anuken.Mindustry.yml

Line 38 in 45c81ac

tag-pattern: '^v([0-9.]+)$'

However, this regex should match v135.1 or v135.2 (note that within square bracktes, the . character is already escaped). Maybe I escaped it incorrectly. I'm not sure if I even tested it, but I forgot how to. Have to test it again sometime later...

[TobTobXX]

Hmm... it seems to work?

~/p/f/com.github.Anuken.Mindustry > flatpak run org.flathub.flatpak-external-data-checker --check-outdated com.github.Anuken.Mindustry.yml                                                      0.492s  (beta) 14:04
INFO    src.manifest: Loading sources from gradle-sources.json
INFO    src.manifest: Checking 238 external data items
INFO    src.manifest: Started check [1/238] git Mindustry (from com.github.Anuken.Mindustry.yml)
INFO    src.manifest: Skipped check [2/238] file gradle-7.3-bin.zip (from com.github.Anuken.Mindustry.yml)
INFO    src.manifest: Skipped check [3/238] file asm-3.3.1.pom (from gradle-sources.json)
[...]
INFO    src.manifest: Skipped check [238/238] file annotations-13.0.jar (from gradle-sources.json)
INFO    src.lib.externaldata: Source Mindustry: got new version 135.2
INFO    src.manifest: Finished check [238/238] git Mindustry (from com.github.Anuken.Mindustry.yml)
CHANGE SOON: Mindustry
 Has a new version:
  URL:       https://github.com/Anuken/Mindustry
  Commit:    41b22ba6a64b748b9dbcb9d0b2fdccc054f0ab17
  Tag:       v135.2
  Branch:    None
  Version:   135.2
  Timestamp: None

INFO    src.main: Check finished with 0 error(s)

No idea why the PR doesn't land.

[TheEvilSkeleton]

Turns out, flatpak-external-data-checker doesn't automatically check for updates if the branch in question isn't the default branch. I implemented e06eb47. Hopefully everything works without a problem.

[TheEvilSkeleton]

#41 was created.