Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta runtime6.4 #12

Merged
merged 27 commits into from
Jan 31, 2023
Merged

Beta runtime6.4 #12

merged 27 commits into from
Jan 31, 2023

Conversation

zocker-160
Copy link
Collaborator

No description provided.

@zocker-160
Copy link
Collaborator Author

Holy shit this protected branches bullshit is so fk annoying.

@flathubbot
Copy link
Contributor

Started test build 15677

@flathubbot
Copy link
Contributor

Build 15677 failed

@dail8859
Copy link
Collaborator

dail8859 commented Jan 6, 2023

Project ERROR: Unknown module(s) in QT: core5compat

Not sure how to configure it to add this extra module but it is needed for Scintilla to compile on Qt6

until it is available in the base runtime (see comments)
@flathubbot
Copy link
Contributor

Started test build 15694

@flathubbot
Copy link
Contributor

Build 15694 failed

because it wants exactly that version ffs
@flathubbot
Copy link
Contributor

Started test build 15695

@flathubbot
Copy link
Contributor

Build 15695 failed

@zocker-160
Copy link
Collaborator Author

hmmm

@flathubbot
Copy link
Contributor

Started test build 15697

@flathubbot
Copy link
Contributor

Build 15697 failed

@flathubbot
Copy link
Contributor

Started test build 15699

@zocker-160
Copy link
Collaborator Author

welp, will have to wait for https://invent.kde.org/packaging/flatpak-kde-runtime/-/issues/26 then ._.

@flathubbot
Copy link
Contributor

Build 15699 failed

@dail8859
Copy link
Collaborator

dail8859 commented Jan 6, 2023

welp, will have to wait for https://invent.kde.org/packaging/flatpak-kde-runtime/-/issues/26 then ._.

Sounds good. Thanks for giving it a shot at least.

@flathubbot
Copy link
Contributor

Started test build 20318

@flathubbot
Copy link
Contributor

Build 20318 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/2954/com.github.dail8859.NotepadNext.flatpakref

@zocker-160
Copy link
Collaborator Author

@dail8859 it compiled o_O

@zocker-160
Copy link
Collaborator Author

It works fairly well actually. Theming is broken as expected, but it falls back to a default theme which I think is not bad at all.
It also does detect dark mode.

Screenshot_20230131_202243

@flathubbot
Copy link
Contributor

Started test build 20320

@flathubbot
Copy link
Contributor

Build 20320 failed

@flathubbot
Copy link
Contributor

Started test build 20322

@flathubbot
Copy link
Contributor

Build 20322 failed

@flathubbot
Copy link
Contributor

Started test build 20324

@flathubbot
Copy link
Contributor

Build 20324 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/2960/com.github.dail8859.NotepadNext.flatpakref

@zocker-160
Copy link
Collaborator Author

There are a few things which are kinda weird but in general it does work, so I am merging into beta.

As for merging to stable, I would not do it if possible, but that is your call.

@zocker-160 zocker-160 merged commit 8610554 into beta Jan 31, 2023
@zocker-160 zocker-160 deleted the beta-runtime6.4 branch January 31, 2023 19:39
@dail8859
Copy link
Collaborator

it compiled o_O

Nice! I guess it seems the qt5compat library is there already then.

As for merging to stable, I would not do it if possible, but that is your call.

I agree holding off for now is fine. There were some nice fixes that Qt6 provided on Windows and MacOS but nothing I know of currently that Linux would benefit from. Although it is not ideal I'm fine sticking with Qt5 on Linux for now until either there is better support through flatpak or there is a very strong need to upgrade to Qt6.

@zocker-160
Copy link
Collaborator Author

Nice! I guess it seems the qt5compat library is there already then.

Yes it got added into the runtime, but it was delayed as they had compilation issues which seem to have been fixed a week ago or so.

Although it is not ideal I'm fine sticking with Qt5 on Linux for now until either there is better support through flatpak or there is a very strong need to upgrade to Qt6.

Makes sense, but even in the last case, it would work good enough I think, I did not encounter any breaking issues while testing.

This was referenced Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants