-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Flextop to 9f66dac #47
Conversation
This should fix #39.
Started test build 44222 |
Build 44222 successful
|
Did a quick test with installing the browser and then installing the youtube pwa. Seems to work fine! |
Well...that's weird, the updated commits don't actually touch the code that detects that. Could you run it with |
Sure, here it is:
By the way, I'm running it with the following flags, but the same issue happens without them: Also, I'm not sure now if this is related to this build, I've noticed now that the flatpak version inherited the webapps from my default Chrome installation and there is a chance that the first webapp that I tried to create earlier was successful because it already existed, now I've tried with a new one. |
@pedrofleck ah apologies, I did a major goof: when you run it with that command, you also need to attempt to install a PWA and let the dialog box appear. Sorry for any wasted time resulting from that! |
No reply, I'm guessing this is an unrelated flextop issue or bugfix, so merged by hand. |
This should fix #39. @ludvigng @pedrofleck please test.