Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GTK4 IM modules #106

Closed
wants to merge 1 commit into from
Closed

Add GTK4 IM modules #106

wants to merge 1 commit into from

Conversation

tinywrkb
Copy link
Contributor

@tinywrkb tinywrkb commented Jan 3, 2022

I'm not sure if we really want to build and package GTK4, so this should be discussed further.
I opened an issue about this in the Chrome packaging repo.

Anyway, this adds the GTK4 IM modules to have Fcitx5 and IBus working with Ozone Wayland.
Updated GTK3 IM modules were also added.

Users need to start the browser with the --gtk-version=4 flag.

Note that Fcitx5 has an IBus backend, and the IBus IM module has popup working, so it's preferable to use the IBus IM module with the Fcitx5 daemon, or just use the IBus daemon.
If you want to stick with Fcitx5 daemon, then set an environment override GTK_IM_MODULE=IBus for Edge in order to use the IBus IM module.

@flathubbot
Copy link
Contributor

Started test build 73244

@flathubbot
Copy link
Contributor

Build 73244 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/71094/com.microsoft.Edge.flatpakref

@flathubbot
Copy link
Contributor

Started test build 73355

@flathubbot
Copy link
Contributor

Build 73355 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/71207/com.microsoft.Edge.flatpakref

@flathubbot
Copy link
Contributor

Started test build 73398

@flathubbot
Copy link
Contributor

Build 73398 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/71250/com.microsoft.Edge.flatpakref

@TheEvilSkeleton
Copy link
Collaborator

@tinywrkb is it done, or do you need more time?

@tinywrkb
Copy link
Contributor Author

tinywrkb commented Jan 5, 2022

@TheEvilSkeleton this is still being discussed, see flathub/com.google.Chrome#107
Feel free to close this. I can create a new PR when a decision will be reached.

@TheEvilSkeleton
Copy link
Collaborator

TheEvilSkeleton commented Jan 5, 2022

No worries! I'm just going to mark it as draft so you can test it and later mark it as ready for review.

@TheEvilSkeleton TheEvilSkeleton marked this pull request as draft January 5, 2022 20:07
@tinywrkb
Copy link
Contributor Author

tinywrkb commented Mar 8, 2022

Closing in favor of adding this to the Chromium base app.

@tinywrkb tinywrkb closed this Mar 8, 2022
@TheEvilSkeleton
Copy link
Collaborator

@tinywrkb can you send a link to the base app? I wasn't aware of one.

@TheEvilSkeleton
Copy link
Collaborator

Found it. Sorry for pinging you flathub/flathub#2886.

@tinywrkb tinywrkb deleted the gtk4imm branch April 30, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants