Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 4.0 #55

Merged
merged 6 commits into from Mar 3, 2023
Merged

Update 4.0 #55

merged 6 commits into from Mar 3, 2023

Conversation

bbhtt
Copy link
Contributor

@bbhtt bbhtt commented Mar 3, 2023 •
edited

Runtime 43 is needed for newer glib 2.74 required by glibmm. I think the issue with openssl 3.0 got resolved since I see transmission/transmission#1777

Switched all gtkmm dependencies to meson and added cleanups.

This built locally but I didn't run it.

Closes #54, closes #46

@flathubbot
Copy link
Contributor

Started test build 26202

@bbhtt bbhtt mentioned this pull request Mar 3, 2023
Closed
@flathubbot
Copy link
Contributor

Build 26202 failed

@flathubbot
Copy link
Contributor

Started test build 26214

@flathubbot
Copy link
Contributor

Build 26214 failed

@flathubbot
Copy link
Contributor

Started test build 26217

@flathubbot
Copy link
Contributor

Build 26217 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8876/com.transmissionbt.Transmission.flatpakref

@bbhtt
Copy link
Contributor Author

bbhtt commented Mar 3, 2023

Getting a Failed to register: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown when trying to run. Probably some access is needed because it works with

flatpak run --socket=session-bus com.transmissionbt.Transmission

@bbhtt
Copy link
Contributor Author

bbhtt commented Mar 3, 2023 •
edited

Looks like they don't have a fixed application id: https://github.com/transmission/transmission/blob/1f1e614f9975399f5c5e847c76f4f61104649726/gtk/Application.cc#L703

eg. com.transmissionbt.transmission_65024_34103683 is getting filtered out

Needs --own-name=com.transmissionbt.* .

@flathubbot
Copy link
Contributor

Started test build 26226

@flathubbot
Copy link
Contributor

Build 26226 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8885/com.transmissionbt.Transmission.flatpakref

@bbhtt
Copy link
Contributor Author

bbhtt commented Mar 3, 2023

Build 26226 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8885/com.transmissionbt.Transmission.flatpakref

Seems to be working fine now

wjt
wjt reviewed Mar 3, 2023
View reviewed changes
Copy link
Member

@wjt wjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I just have one question:

com.transmissionbt.Transmission.json Outdated Show resolved Hide resolved
@flathubbot
Copy link
Contributor

Started test build 26242

Amanse and others added 6 commits March 3, 2023 21:07
@Amanse @bbhtt
Update version
8b4fc8a
@bbhtt
Update gtkmm and dependencies
ce5788e
@bbhtt
Update old patches and remove icon patch
2c076fa
@bbhtt
Cleanups
a6f8548
@bbhtt
Fix appdata name
f48aa47
@bbhtt
Add dri permission
efb074d 
 - dri - Running on wayland shows `libEGL warning: wayland-egl:
   could not open /dev/dri/renderD128 (No such file or directory)`
@flathubbot
Copy link
Contributor

Build 26242 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8901/com.transmissionbt.Transmission.flatpakref

@flathubbot
Copy link
Contributor

Started test build 26244

@flathubbot
Copy link
Contributor

Build 26244 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/8903/com.transmissionbt.Transmission.flatpakref

@wjt wjt merged commit 9977987 into flathub:master Mar 3, 2023
@wjt
Copy link
Member

wjt commented Mar 3, 2023

Thanks. Would you like commit access to this repo?

@Amanse
Copy link
Contributor

Amanse commented Mar 3, 2023

nice lessgoooo

@bbhtt bbhtt deleted the update-4.0 branch March 4, 2023 04:39
@bbhtt
Copy link
Contributor Author

bbhtt commented Mar 4, 2023

Thanks. Would you like commit access to this repo?

No, but thanks. I'll try to send PRs if I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjt wjt wjt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.0 Update Gnome Runtime 43 breaks this app
4 participants
@bbhtt @flathubbot @wjt @Amanse