Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing /.flatpak-info #1201

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix parsing /.flatpak-info #1201

merged 1 commit into from
Dec 8, 2023

Conversation

TingPing
Copy link
Member

@TingPing TingPing commented Dec 1, 2023

The /.flatpak-info is a keyfile in the format described by the desktop-entry-spec.

It is not a format that the Python configparser module can correctly parse.

The most accessible and certainly correct implementation of this is GLib.Keyfile so I switched it to this.

@flathubbot
Copy link
Contributor

Started test build 84892

@flathubbot
Copy link
Contributor

Build 84892 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/67543/com.valvesoftware.Steam.flatpakref

@nanonyme
Copy link
Collaborator

nanonyme commented Dec 7, 2023

This looks otherwise great but I don't understand the py3cairo connection. Can you please explain how it comes to the picture?

The `/.flatpak-info` is a keyfile in the format describe by the desktop-entry-spec.

It is *not* a format that the Python configparser module can correctly parse.

The most accessible and certainly correct implementation of this is GLib.Keyfile
so I switched it to this.
@flathubbot
Copy link
Contributor

Started test build 86127

@flathubbot
Copy link
Contributor

Build 86127 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/68791/com.valvesoftware.Steam.flatpakref

@TingPing
Copy link
Member Author

TingPing commented Dec 7, 2023

It's just a dependency of pygobject. Installing it with pip didn't work.

@barthalion barthalion merged commit 1fe582a into beta Dec 8, 2023
1 check passed
@barthalion barthalion deleted the pgriffis/keyfile branch December 8, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants