Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pressure-vessel's overrides data dir to XDG_DATA_DIRS #1281

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

jntesteves
Copy link
Contributor

@jntesteves jntesteves commented Mar 29, 2024

This is a hack until the underlying issue is fixed in the steam-runtime. Pressure-vessel mounts Flatpak extensions on a different path within the container, and that breaks Vulkan Layers due to that path not being in Vulkan-Loader's search paths, documented on: https://github.com/KhronosGroup/Vulkan-Loader/blob/main/docs/LoaderLayerInterface.md#linux-layer-discovery

This directory doesn't exist outside a pressure-vessel container, which is only used by games and not by all of them. But still, adding it to XDG_DATA_DIRS in finish-args shouldn't cause any adverse effect, as these search paths are not required to be all valid.

fixes #1280
related to ValveSoftware/steam-runtime#662

This is a hack until the underlying issue is fixed in the steam-runtime. Pressure-vessel mounts Flatpak extensions on a different path within the container, and that breaks Vulkan Layers due to that path not being in Vulkan-Loader's search paths, documented on: https://github.com/KhronosGroup/Vulkan-Loader/blob/main/docs/LoaderLayerInterface.md#linux-layer-discovery

This directory doesn't exist outside a pressure-vessel container, which is only used by games and not by all of them. But still, adding it to XDG_DATA_DIRS in finish-args shouldn't cause any adverse effect, as these search paths are not required to be all valid.

fixes flathub#1280
@flathubbot
Copy link
Contributor

Started test build 110765

@flathubbot
Copy link
Contributor

Build 110765 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/93583/com.valvesoftware.Steam.flatpakref

@jntesteves
Copy link
Contributor Author

I've reported the issue to upstream, and updated the description with a link to it. We could probably drop this change in the future if upstream resolves the problem in steam-runtime.

@jtdorseyiii
Copy link

I just tried this, and can report that MangoHud is once again working. A bit of an oddity I had was that my presets.conf file was nowhere to be found, but I just copied from the main MangoHud repo and the HUD magically appeared!

Thank you @jntesteves for this workaround!!

@zastrixarundell
Copy link

This fixes:

  • MangoHud
  • VKBASALT
  • OBS VKcapture

@rowbawts
Copy link

rowbawts commented Apr 2, 2024

Is the reason why this only went to beta due to the fact that its considered a "hack"?

@jntesteves
Copy link
Contributor Author

Is the reason why this only went to beta due to the fact that its considered a "hack"?

No. It went to beta because that's where all contributions to this package go, to be tested, and at a later time, at the maintainers' discretion and whenever they have the time, will be promoted to the stable channel.

@rowbawts
Copy link

rowbawts commented Apr 2, 2024

No. It went to beta because that's where all contributions to this package go, to be tested, and at a later time, at the maintainers' discretion and whenever they have the time, will be promoted to the stable channel.

Understood

@bbhtt
Copy link

bbhtt commented Apr 3, 2024

Pushed to stable now ee35853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MangoHud and vkBasalt stopped working without apparent reason
6 participants