Upgrade to a newer NSS to fix Store display #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot, build |
|
bot, build |
|
Agrees on needing attention. Needing to bundle dep in many apps smells like problem in runtime |
|
There will be a new FDo runtime at some point fairly soon, which will update a lot of things. Certainly getting GCC7 in a runtime would be helpful for some apps, but that's more of an issue for https://github.com/flatpak/freedesktop-sdk-images |
|
@nanonyme can you merge this? or is there anything more you want done? I've confirmed that this fixes the issue in local testing. |
|
OK - since this fixes a highly user visible issue and has been tested to be OK I'm going to merge, but happy to take post-hoc review/fixes as necessary. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #47
This initially copies the section from com.spotify.Spotify, since that should actually have received some testing but this may need further attention.