Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

Why does gradio need --filesystem=host acess? #8

Closed
AdrianKoshka opened this issue Nov 3, 2018 · 6 comments
Closed

Why does gradio need --filesystem=host acess? #8

AdrianKoshka opened this issue Nov 3, 2018 · 6 comments

Comments

@AdrianKoshka
Copy link

I was wondering why this flatpak needs --filesystem=host access. That's a rather large portion of the sandbox to open. Gradio seems to run fine if you revoke --filesystem=host acess.

@haecker-felix
Copy link
Collaborator

You're right, there's no reason why Gradio should have access to everything. I have now limited access to "--filesystem=home".

Gradio needs acess to import/export the library.

@TingPing
Copy link
Member

TingPing commented Nov 3, 2018

Ugh host -> home is a silly change. It only annoys users and doesn't in any way improve security.

Gradio needs acess to import/export the library.

What exactly does the library refer to?

@haecker-felix
Copy link
Collaborator

haecker-felix commented Nov 3, 2018

@TingPing i know, it's better to use the flatpak FileChooser portal, than granting access to the complete home folder. I have to implement this.

What exactly does the library refer to?

The library (which contains the radio stations) itself lies under "/home/user/.var/app/de.haeckerfelix.gradio/.../gradio.db", which is fine. However the user can export the library to somewhere else, or import it from somewhere else.

@AdrianKoshka
Copy link
Author

AdrianKoshka commented Nov 3, 2018

Personal suggestion, no --filesystem=home, and instead maybe --filesystem=xdg-downloads to export/import the library to/from?

@TingPing
Copy link
Member

TingPing commented Nov 3, 2018

Using GtkFileChooserNative is a very simple change. I suggest not worrying about permissions until that is implemented.

@haecker-felix
Copy link
Collaborator

Gradio uses GtkFileChooserNative now => We don't need require "--filesystem=home" anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants