Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop file test (beta) #50

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Desktop file test (beta) #50

merged 4 commits into from
Dec 20, 2023

Conversation

anarcat
Copy link
Collaborator

@anarcat anarcat commented Dec 20, 2023 •
edited

This MR brings the "beta" branch up to date with the 0.8.2 flatpak and syncs with the latest upstream (currently dweymouth/supersonic@61f5f24) to see if it will fix the menu category.

Closes: #47

/cc @webmind

@flathubbot
Copy link
Contributor

Started test build 89077

@anarcat anarcat mentioned this pull request Dec 20, 2023
Closed
@flathubbot
Copy link
Contributor

Build 89077 failed

@flathubbot
Copy link
Contributor

Started test build 89087

@anarcat
update modules
480b493
@anarcat
deploy upstream's desktop app
c8fa98c 
There was something odd here: the .desktop file was named
`Supersonic.desktop`, yet the upstream guide says:

> Your desktop file should be prefixed with your application’s appid
> and placed in /app/share/applications/ within your app.
>
> Example:
>
> /app/share/applications/org.gnome.Dictionary.desktop

Source:
https://docs.flatpak.org/en/latest/freedesktop-quick-reference.html#desktop-files

So let's try to fix that as well.
@flathubbot
Copy link
Contributor

Started test build 89089

@flathubbot
Copy link
Contributor

Build 89087 was cancelled

@flathubbot
Copy link
Contributor

Build 89089 failed

@anarcat
Copy link
Collaborator Author

anarcat commented Dec 20, 2023

so interestingly, that last build failed with:

Error: Error moving file /srv/buildbot/worker/build-x86_64-1/build/.flatpak-builder/rofiles/rofiles-f7LW6w/files/share/applications/Supersonic.desktop: File exists

... that is because the desktop file, well, it already exists. :p and indeed, there is one shipped as part of the build, so we don't really need to do anything special here: the desktop file is already shipped!

i'll note, however, that it doesn't match the file in the source tree (https://github.com/dweymouth/supersonic/blob/61f5f24c4f58f499f6429dcd9d668d4900c46001/res/supersonic-desktop.desktop):

anarcat@angela:~$ tar -x -O -f  Supersonic-0.8.2-linux-x64.tar.xz usr/local/share/applications/Supersonic.desktop;  echo
[Desktop Entry]
Type=Application
Name=Supersonic
Exec=supersonic 
Icon=Supersonic
Keywords=fyne;

that's the file @dweymouth was saying is the one generated by Fyne... so in a sense, this is a bug in the upstream build process...

i'll find a workaround, i think it's just to replace the file manually...

@flathubbot
Copy link
Contributor

Started test build 89096

@anarcat anarcat mentioned this pull request Dec 20, 2023
Open
@anarcat
Copy link
Collaborator Author

anarcat commented Dec 20, 2023

that's the file @dweymouth was saying is the one generated by Fyne... so in a sense, this is a bug in the upstream build process...

i filed dweymouth/supersonic#302 about that.

@flathubbot
Copy link
Contributor

Build 89096 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/71772/io.github.dweymouth.supersonic.flatpakref

@anarcat anarcat merged commit 3257005 into beta Dec 20, 2023
1 check passed
@anarcat anarcat deleted the desktop-test branch December 20, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anarcat @flathubbot