Update to 2.3.3

[catsout]

No description provided.

[flathubbot]

Started test build 56360

[flathubbot]

Build 56360 failed

[catsout]

bot, build net.cozic.joplin_desktop

[flathubbot]

Queued test build for net.cozic.joplin_desktop.

[flathubbot]

Started test build 56388

[flathubbot]

Build 56388 was cancelled

[flathubbot]

Started test build 56390

[catsout]

@nedrichards
The flathub bot will stuck at downloading sources.

[flathubbot]

Build 56390 failed

[flathubbot]

Started test build 56416

[catsout]

@barthalion
The flathub bot will stuck at downloading sources.

[flathubbot]

Build 56416 failed

[tinywrkb]

@catsout

Try adding sed -i 's#git+ssh://git@#https://#' generated-sources.json to the workflow.

[flathubbot]

Started test build 56533

[flathubbot]

Build 56533 failed

[flathubbot]

Started test build 56536

[flathubbot]

Build 56536 was cancelled

[flathubbot]

Started test build 56538

[flathubbot]

Build 56538 failed

[tinywrkb]

Post the Replace 'git+ssh' to http commit and with the following the build is failing in a bit later while running git ls-remote -h -t due to the fact network is not available.

diff --git a/net.cozic.joplin_desktop.yml b/net.cozic.joplin_desktop.yml
index f1315ef..74c0fef 100644
--- a/net.cozic.joplin_desktop.yml
+++ b/net.cozic.joplin_desktop.yml
@@ -61,6 +61,7 @@ modules:
         npm_config_no_save: 'true'
         npm_config_loglevel: silly
     build-commands:
+      - sed -i 's#git+ssh://git@\(github.com/laurent22\)#git://\1#' packages/{app-cli,lib,renderer}/package-lock.json
       - npm install
       # generateSha512.js require appimage build, need touch it
       # If no it will cause electron-builder failed without error message even set debug!

I don't know if there's a way to disable the git ls-remote, so upstream might need to switch to a tarball source instead of git.
The alternative is to regenerate the package-lock.json during the auto-update workflow, add them here to the repo, and copy over the upstream's ones before running npm install when building the package.

Another reason why upstream should consider switching to tarballs instead of git is this issue.

/ping @laurent22

[flathubbot]

Started test build 56540

[flathubbot]

Started test build 56541

[flathubbot]

Build 56540 was cancelled

[flathubbot]

Build 56541 was cancelled

[laurent22]

@tinywrkb, I'm not familiar with these problems. What's causing an issue in Joplin repo?

[catsout]

Post the Replace 'git+ssh' to http commit and with the following the build is failing in a bit later while running git ls-remote -h -t due to the fact network is not available.

npm find a package with git url:https://github.com, but there is no network.
The flatpak-builder-tools will create some script to replace this git url to local git+file:// url
But seems the npm change it's behavior, which make the script do not replace the git url
Need to write extra code on my fork of flatpak-builder-tools

[flathubbot]

Started test build 56542

[flathubbot]

Build 56542 failed

[catsout]

WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!

[flathubbot]

Started test build 56545

[flathubbot]

Build 56545 failed

[tinywrkb]

@laurent22 as @catsout pointed out, there are some difficulties of building in offline mode when there are node modules with git sources. To work around them, some changes are needed to be made to the Flatpak packaging helpers, flatpak-builder-tools.
These issues could be avoided if only tarball sources were used, at least for tagged releases, though it's better to fix flatpak-builder-tools.

[catsout]

@tinywrkb
I think the git source has been fixed by a1dcedb
The build now failed with fs-extra, which may caused by the new lockfile version.Need more test to find why npm requires to fetch fresh package.

[flathubbot]

Started test build 56598

[catsout]

Seems like it's the same issue as laurent22/joplin#4478
Just patch to same version.

[flathubbot]

Build 56598 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/54524/net.cozic.joplin_desktop.flatpakref