-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update runtime to 6.2 #10
Conversation
This is the KDE Runtime with Qt 6.2 but no KDE libraries for now.
Started test build 69378 |
Build 69378 failed |
There isn't support for qt5compat in the KDE 6.2 SDK. Maybe, in future releases of VMPK, the 'qt5compat' module could be dropped. But for other programs like dmidiplayer the problem is the absence of text codecs other than Unicode. MIDI files can contain text metadata (as lyrics) using a variety of encodings. |
That might be needed by other apps too. Maybe we should add it to the SDK. |
I agree. Maybe it was already considered and excluded for some reason? What do you think @aleixpol? |
when I suggested the 6.2 SDK I assumed that it was because you had a port to Qt6 (from previous mentions). But if you don't there is no point in using that runtime. |
I've ported VMPK (and my other programs) to Qt6 using the compatibility module which is part of Qt6, but was not included in the KDE 6.2 SDK for some reason. |
I filed an issue for qt5compat: https://invent.kde.org/packaging/flatpak-kde-runtime/-/issues/26 |
Hi @pedrolcl! Long time no see!! Well I replied there but I can reply here too. It could make sense to keep qt5compat in the app, it shouldn't be too hard to build, we did something similar for Qt 5 anyway for some apps. Otherwise, we can agree that for now everyone is porting so we add it there too, but I'd prefer if it wasn't for the lack of trying. |
There are two use cases for the Qt6 Core5Compat module:
The second use case is much more serious, but VMPK has nothing to do with it. The next VMPK release will be able to use Qt6.2 cleanly, bundling only the Drumstick-2.5.0 modules RT+Widgets, without the File module. Meanwhile, let's keep the 5.15 runtime, please. |
Definitely. There is no pressure to move here. This was mostly a test / conversation starter. Feel free to update when progress has been made. Thanks! |
Started test build 71989 |
Build 71989 successful
|
I've tested the last build briefly, and seems OK but...
The drumstick libs is 2.5.0 excluding Drumstick::File explicitly, so the qt5compat module is not required here. Please test! |
Started test build 72086 |
Build 72086 successful
|
This is the KDE Runtime with Qt 6.2 but no KDE libraries for now.
Let's try this one and see if it works. This is a bigger change than #9 thus careful testing might be needed.