Include libspeechd for SpeechSynthesis support #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Started test build 131050 |
bbhtt
reviewed
Jun 28, 2024
bbhtt
reviewed
Jun 28, 2024
|
Build 131050 successful |
bbhtt
reviewed
Jun 28, 2024
|
Started test build 131055 |
|
Build 131055 failed |
|
bot, build |
|
Queued test build for org.electronjs.Electron2.BaseApp. |
|
Started test build 131058 |
|
Build 131058 successful |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron apps may want to use the SpeechSynthesis part of the Web Speech API.
On Linux, this is gated behind the
--enable-speech-dispatcherflag. If enabled, Chromium will attempt to dynamically load the Speech Dispatcher librarylibspeechd.so.2. If not present, speech is disabled. Chromium source code for proof. Right now this library isn't included inside the Flatpak, even though the host may be fully configured with Speech Dispatcher.This PR builds and includes the library (but not the daemon) so that TTS stuff can easily work as long as the consuming app passes the
--enable-speech-dispatcherflag and has sandbox perms for--filesystem=xdg-run/speech-dispatcher.This is useful for flathub/dev.vencord.Vesktop#20, though we thought it'd make sense to upstream it for other apps' benefit.