Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for freedesktop-sdk 21.08beta #5

Merged
merged 2 commits into from Jul 28, 2021
Merged

Conversation

abderrahim
Copy link
Contributor

@abderrahim abderrahim commented Jul 26, 2021

This needs to be merged to a branch named beta. Until such a branch is created, I'm keeping it a draft

Fixes #4

@flathubbot
Copy link

Started test build 54396

@abderrahim
Copy link
Contributor Author

What's -Qunused-arguments? and why is it enabled only on aarch64?

@flathubbot
Copy link

Build 54396 failed

@flathubbot
Copy link

Started test build 54398

@flathubbot
Copy link

Build 54398 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/52347/org.freedesktop.Sdk.Extension.llvm12.flatpakref

@Lctrs
Copy link
Collaborator

Lctrs commented Jul 26, 2021

beta branch has been created.

@abderrahim abderrahim changed the base branch from branch/20.08 to beta July 26, 2021 13:45
@abderrahim abderrahim marked this pull request as ready for review July 26, 2021 13:46
@abderrahim
Copy link
Contributor Author

Thanks, this is now ready. I'm not sure about the -Qunused-arguments on aarch64, but it works fine on x86_64.

@flathubbot
Copy link

Started test build 54413

@abderrahim
Copy link
Contributor Author

Seems you pushed (something equivalent to) one of the commits when creating the branch. I rebased on top of that.

@flathubbot
Copy link

Build 54413 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/52362/org.freedesktop.Sdk.Extension.llvm12.flatpakref

@Erick555
Copy link
Collaborator

What's -Qunused-arguments? and why is it enabled only on aarch64?

Se 1ea7d9a for explanation. It's needed only when build with clang. I think ideally we should make 2-stage build when 1-stage is temporary compiler build with gcc then 2-stage is full featured llvm build with compiler from stage 1.

@Erick555
Copy link
Collaborator

Size of extension build with gcc is 941.0 MB while current is 580.8 MB which illustrates why 2-stage build may be desirable here.

@jjardon
Copy link

jjardon commented Jul 28, 2021

@Erick555 @Lctrs would it be possible to land this soonish? This is blocking the update of GNOME to new freedesktop-sdk base: https://gitlab.gnome.org/GNOME/gnome-build-meta/-/merge_requests/1238

@barthalion barthalion merged commit d57f797 into flathub:beta Jul 28, 2021
@abderrahim
Copy link
Contributor Author

I've opened #6 for the two-stage build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish 21.08beta version to flathub-beta
6 participants