Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GNOME runtime 40 #29

Merged
merged 1 commit into from Apr 5, 2021
Merged

Conversation

A6GibKm
Copy link
Contributor

@A6GibKm A6GibKm commented Mar 27, 2021

No description provided.

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Mar 27, 2021

Some module were not updated, e.g. libgweather as the compiler complained.

@bilelmoussaoui
Copy link
Member

bot, build

@flathubbot
Copy link
Contributor

Queued test build for org.gnome.Calendar.

@flathubbot
Copy link
Contributor

Started test build 43014

@flathubbot
Copy link
Contributor

Build 43014 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/41382/org.gnome.Calendar.flatpakref

@X-m7
Copy link

X-m7 commented Mar 27, 2021

Some module were not updated, e.g. libgweather as the compiler complained.

What was the issue here? I tried your branch plus libgweather 40.0 locally and it compiles. Granted, the weather part doesn't seem to actually work (GWeather-CRITICAL **: 09:34:32.217: gweather_info_update: assertion 'info->contact_info != NULL' failed in the terminal, and no weather info appears), but otherwise it looks fine to me.

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Mar 27, 2021

Ugh, it just said that meson was not supported or something like that (?), I did not look much into it to be honest. The other modules were mostly me not knowing what else required an update.

@X-m7
Copy link

X-m7 commented Mar 28, 2021

You might want to try updating your flatpaks I suppose, in case there was an update to the SDK or something. Anyway, some of the other dependencies have updates too, so I've sent a PR to your fork for that (linked below this comment)

@go-ten
Copy link

go-ten commented Apr 1, 2021

Hi,

Any news about this PR ?

@bilelmoussaoui
Copy link
Member

Some module were not updated, e.g. libgweather as the compiler complained.

What was the issue here? I tried your branch plus libgweather 40.0 locally and it compiles. Granted, the weather part doesn't seem to actually work (GWeather-CRITICAL **: 09:34:32.217: gweather_info_update: assertion 'info->contact_info != NULL' failed in the terminal, and no weather info appears), but otherwise it looks fine to me.

lt depends on whether Calendar was updated to use the new libgweather 40 API or not.

@X-m7
Copy link

X-m7 commented Apr 1, 2021

lt depends on whether Calendar was updated to use the new libgweather 40 API or not.

According to this it's been updated enough to compile at least, which it does on my machine.

@bilelmoussaoui
Copy link
Member

@A6GibKm do you mind bumping libgweather & goa as well?

@flathubbot
Copy link
Contributor

Started test build 43778

@flathubbot
Copy link
Contributor

Build 43778 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/42122/org.gnome.Calendar.flatpakref

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Apr 2, 2021

@bilelmoussaoui I am not able to build goa. Seems whatever they do in the flatpak manifest upstream uses master features which are not even in 3.9.

@X-m7
Copy link

X-m7 commented Apr 2, 2021

I am not able to build goa. Seems whatever they do in the flatpak manifest upstream uses master features which are not even in 3.9.

Which version did you try? The latest release is 3.38.1 still, that again compiles fine on my system. There is a 3.40 branch on GItLab but they haven't actually tagged a release from it yet.

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Apr 2, 2021

I tried using 3.8.5 without success.

@X-m7
Copy link

X-m7 commented Apr 2, 2021

I tried using 3.8.5 without success.

Makes sense, that was all the way back from 2013, easy mistake to make if you were just scrolling through https://download.gnome.org/sources/gnome-online-accounts/.

@flathubbot
Copy link
Contributor

Started test build 43799

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Apr 3, 2021

I found the issue.... I was using 3.8 rather than 3.38..

@flathubbot
Copy link
Contributor

Build 43799 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/42142/org.gnome.Calendar.flatpakref

@flathubbot
Copy link
Contributor

Started test build 43878

@flathubbot
Copy link
Contributor

Build 43878 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/42216/org.gnome.Calendar.flatpakref

@bilelmoussaoui
Copy link
Member

Lgtm, thanks!

@bilelmoussaoui bilelmoussaoui merged commit f92a000 into flathub:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants