Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove buildtype=release #20

Closed
wants to merge 1 commit into from
Closed

Remove buildtype=release #20

wants to merge 1 commit into from

Conversation

A6GibKm
Copy link
Collaborator

@A6GibKm A6GibKm commented Mar 21, 2024

This is not needed.

cc @alatiera

@alatiera
Copy link
Member

Looks good

@A6GibKm
Remove buildtype=release
a3271cb 
This is not needed.
@flathubbot
Copy link
Contributor

Started test build 108784

@flathubbot
Copy link
Contributor

Build 108784 failed

@bbhtt
Copy link
Contributor

bbhtt commented Mar 22, 2024

bot, build

@flathubbot
Copy link
Contributor

Queued test build for org.gnome.Gtranslator.

@flathubbot
Copy link
Contributor

Started test build 108906

@flathubbot
Copy link
Contributor

Build 108906 failed

@bbhtt
Copy link
Contributor

bbhtt commented Mar 22, 2024 


      GTranslator 46.0
      =========================

          Source ..........................: /run/build/gtranslator
          Prefix ..........................: /app
          Compiler ........................: gcc
          libspell ........................: enabled

      Development options
          Enable Debug: ...................: true <---
          Enable Documentation: ...........: false

is chaning launchable to Devel suffix

@flathubbot
Copy link
Contributor

Started test build 108934

@flathubbot
Copy link
Contributor

Build 108934 failed

gnomesysadmins pushed a commit to GNOME/gtranslator that referenced this pull request Mar 25, 2024
@A6GibKm
meson: Do not use buildtype
9839725 
We already have a profile option. This is done to match what other apps
use. Having two flags to signal that the app is development is a bit
confusing.

See flathub/org.gnome.Gtranslator#20
@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Mar 31, 2024

Will be implemented with 46.1. Closing.

@A6GibKm A6GibKm closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@A6GibKm @alatiera @flathubbot @bbhtt