New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 3.38 #24
Update to 3.38 #24
Conversation
A6GibKm
commented
Oct 1, 2020
- Update gnome runtime
- Added gst-python patch
- Removed tracker, use portal instead
- Added tracker-miners following upstream manifest
- Use fallback-x11 socket, following upstream manifest
Started test build 28892 |
Build 28892 failed |
Started test build 28900 |
Build 28900 successful
|
@bilelmoussaoui is there anything to have in mind here? |
@A6GibKm Thank you for working on this. You introduce a lot of changes in your commit. Could you split it into multiple commits please. This way it will be easier to drop the gstreamer patch once it's not necessary anymore:
|
Yes of course, I did it this way to ensure having only working commits (this applies to the patch). Will do. |
- Update runtime to 3.38 - Switch to Tracker3
Started test build 28960 |
@ptitjano I should had mention you for a review, sorry about that. I separated into 4 commits. There is an issue with tracker when on first run it won't show music in the app. Edit: The tracker issue might be related to lingering files at |
Build 28960 successful
|
I was actually testing the wrong build before (forgot |
@ssssam I noticed the same thing on first(fresh) run. (gnome-music:2): Gtk-WARNING **: 09:03:05.376: Locale not supported by C library.
Using the fallback 'C' locale.
** (gst-plugin-scanner:5): CRITICAL **: 09:03:05.412: Couldn't g_module_open libpython. Reason: /usr/lib/x86_64-linux-gnu/libpython3.8.so: cannot open shared object file: No such file or directory
(org.gnome.Music:2): org.gnome.Music-WARNING **: 09:03:06.177: (trackerwrapper.py, _setup_host_miner_fs, 84) Could not connect to host Tracker miner-fs at org.freedesktop.Tracker3.Miner.Files: g-dbus-error-quark: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface “org.freedesktop.portal.Tracker” on object at path /org/freedesktop/portal/Tracker (19) |
The portal is currently first claiming the bus name, then adding the portal object+interface. This may break things with autostart as clients are able to send a message to an object path that is not there yet. Changing the order means the object path is there when the DBus name is made known, so clients are able to talk immediately to it. Fixes the error reported at flathub/org.gnome.Music#24 (comment)
FTR, https://gitlab.gnome.org/GNOME/tracker/-/merge_requests/322 |
Right, I don't know why but I had the idea that it was used upstream. Removing it. |
I don't know when the changes merged in https://gitlab.gnome.org/GNOME/tracker/-/merge_requests/322 will be reflected on the user's end. I suppose that that is the proper timing to merge this. |
The fix missed Tracker 3.0.1 by a few days, will be in 3.0.2 (I suppose will be released in one or two weeks). Since this is a fix for the portal service in the host, just affects distros that adopted 3.0 early, and the next app restart should work, I wonder if it's that much critical to have the fix in place. |
Started test build 29405 |
Build 29405 successful
|