Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.38 #24

Merged
merged 4 commits into from Oct 6, 2020
Merged

Update to 3.38 #24

merged 4 commits into from Oct 6, 2020

Conversation

A6GibKm
Copy link
Contributor

@A6GibKm A6GibKm commented Oct 1, 2020

  • Update gnome runtime
  • Added gst-python patch
  • Removed tracker, use portal instead
  • Added tracker-miners following upstream manifest
  • Use fallback-x11 socket, following upstream manifest

@flathubbot
Copy link
Contributor

Started test build 28892

@flathubbot
Copy link
Contributor

Build 28892 failed

@flathubbot
Copy link
Contributor

Started test build 28900

@flathubbot
Copy link
Contributor

Build 28900 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27821/org.gnome.Music.flatpakref

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Oct 1, 2020

@bilelmoussaoui is there anything to have in mind here?

@ptitjano
Copy link
Collaborator

ptitjano commented Oct 1, 2020

@A6GibKm Thank you for working on this. You introduce a lot of changes in your commit. Could you split it into multiple commits please. This way it will be easier to drop the gstreamer patch once it's not necessary anymore:

  • 1 commit to add the patch
  • 1 commit to introduce the fallback-x11 change
  • 1 commit to update to 3.38

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Oct 1, 2020

Yes of course, I did it this way to ensure having only working commits (this applies to the patch). Will do.

- Update runtime to 3.38
- Switch to Tracker3
@flathubbot
Copy link
Contributor

Started test build 28960

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Oct 1, 2020

@ptitjano I should had mention you for a review, sorry about that. I separated into 4 commits. There is an issue with tracker when on first run it won't show music in the app.

Edit: The tracker issue might be related to lingering files at ~/.var maybe.

@flathubbot
Copy link
Contributor

Build 28960 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27882/org.gnome.Music.flatpakref

@A6GibKm A6GibKm marked this pull request as draft October 1, 2020 22:52
@ssssam
Copy link

ssssam commented Oct 1, 2020

I tried the test build and saw this

I was actually testing the wrong build before (forgot --branch=test arg to flatpak run). On Fedora 33 the test build seems to work as expected for me.

@fosero
Copy link
Collaborator

fosero commented Oct 2, 2020

@ssssam I noticed the same thing on first(fresh) run.

(gnome-music:2): Gtk-WARNING **: 09:03:05.376: Locale not supported by C library.
	Using the fallback 'C' locale.

** (gst-plugin-scanner:5): CRITICAL **: 09:03:05.412: Couldn't g_module_open libpython. Reason: /usr/lib/x86_64-linux-gnu/libpython3.8.so: cannot open shared object file: No such file or directory

(org.gnome.Music:2): org.gnome.Music-WARNING **: 09:03:06.177: (trackerwrapper.py, _setup_host_miner_fs, 84) Could not connect to host Tracker miner-fs at org.freedesktop.Tracker3.Miner.Files: g-dbus-error-quark: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface “org.freedesktop.portal.Tracker” on object at path /org/freedesktop/portal/Tracker (19)

gnomesysadmins pushed a commit to GNOME/tracker that referenced this pull request Oct 4, 2020
The portal is currently first claiming the bus name, then adding
the portal object+interface. This may break things with autostart
as clients are able to send a message to an object path that is not
there yet.

Changing the order means the object path is there when the DBus name
is made known, so clients are able to talk immediately to it.

Fixes the error reported at
flathub/org.gnome.Music#24 (comment)
@garnacho
Copy link

garnacho commented Oct 4, 2020

(org.gnome.Music:2): org.gnome.Music-WARNING **: 09:03:06.177: (trackerwrapper.py, _setup_host_miner_fs, 84) Could not connect to host Tracker miner-fs at org.freedesktop.Tracker3.Miner.Files: g-dbus-error-quark: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: No such interface “org.freedesktop.portal.Tracker” on object at path /org/freedesktop/portal/Tracker (19)

FTR, https://gitlab.gnome.org/GNOME/tracker/-/merge_requests/322

@ptitjano
Copy link
Collaborator

ptitjano commented Oct 5, 2020

Thank you @garnacho for the explanation and the fix.

@A6GibKm Why do you add the ffmpeg extension? As far as I understand, we don't need it.

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Oct 5, 2020

Right, I don't know why but I had the idea that it was used upstream. Removing it.

@A6GibKm A6GibKm marked this pull request as ready for review October 5, 2020 14:26
@A6GibKm
Copy link
Contributor Author

A6GibKm commented Oct 5, 2020

I don't know when the changes merged in https://gitlab.gnome.org/GNOME/tracker/-/merge_requests/322 will be reflected on the user's end. I suppose that that is the proper timing to merge this.

@garnacho
Copy link

garnacho commented Oct 5, 2020

I don't know when the changes merged in https://gitlab.gnome.org/GNOME/tracker/-/merge_requests/322 will be reflected on the user's end. I suppose that that is the proper timing to merge this.

The fix missed Tracker 3.0.1 by a few days, will be in 3.0.2 (I suppose will be released in one or two weeks).

Since this is a fix for the portal service in the host, just affects distros that adopted 3.0 early, and the next app restart should work, I wonder if it's that much critical to have the fix in place.

@flathubbot
Copy link
Contributor

Started test build 29405

@flathubbot
Copy link
Contributor

Build 29405 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/28318/org.gnome.Music.flatpakref

@ptitjano ptitjano merged commit 6b8350f into flathub:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants