Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case mismatch? org.gtk.Gtk3theme.Yaru-Red-dark vs Yaru-red-dark #1

Open
ernstp opened this issue Mar 30, 2022 · 15 comments
Open

Case mismatch? org.gtk.Gtk3theme.Yaru-Red-dark vs Yaru-red-dark #1

ernstp opened this issue Mar 30, 2022 · 15 comments

Comments

@ernstp
Copy link

ernstp commented Mar 30, 2022

I get legacy integration with Evolution from flathub when I have "Yaru-dark" selected, but not with "Yaru-red-dark".
Is it because the flatpak theme is called Yaru-Red-dark with an uppercase R perhaps.. ?

@Mek101
Copy link
Collaborator

Mek101 commented Mar 31, 2022

That should the cause. I don't know for sure which capitalization is right though. From where did you get get it from?

@ernstp
Copy link
Author

ernstp commented Mar 31, 2022

In gnome-tweaks you can see that the theme name is "Yaru-red-dark". And this Flatpak stuff is named Yaru-Red-dark.

@Mek101
Copy link
Collaborator

Mek101 commented Mar 31, 2022

How are the other colors capitalized?

@ernstp
Copy link
Author

ernstp commented Apr 1, 2022

It's the same pattern with all the other colors!

@3v1n0
Copy link

3v1n0 commented Apr 5, 2022

The problem is not only on naming, but mostly that this repo should now be rebased on upstream Yaru that supports color variants.

Old variants are not supported upstream, where just a fork.

@Mek101
Copy link
Collaborator

Mek101 commented Apr 5, 2022

The problem is not only on naming, but mostly that this repo should now be rebased on upstream Yaru that supports color variants.

I just package the themes into flatpaks, you should go and ask at https://github.com/Jannomag/Yaru-Colors for an upstream rebase

Old variants are not supported upstream, where just a fork.

I... don't understand this phrase

@3v1n0
Copy link

3v1n0 commented Apr 5, 2022

I just package the themes into flatpaks, you should go and ask at https://github.com/Jannomag/Yaru-Colors for an upstream rebase

Nope, I don't expect that repository to be maintained as it is, now upstream Yaru supports different colors natively so this repo should be changed to track that instead.

Old variants are not supported upstream, where just a fork.

I... don't understand this phrase

Sorry I put an extra h, but I meant that Yaru-Colors is a fork of upstream Yaru, and it's not something that should be used anymore.

@3v1n0
Copy link

3v1n0 commented Apr 5, 2022

So something like this (untested) should be done: 3v1n0@a11a8b9

@3v1n0
Copy link

3v1n0 commented Apr 5, 2022

As mentioned by @ernstp it's very likely that the name case mismatch is causing issues though, so in such case we should probably open a new repo for this?

@Mek101
Copy link
Collaborator

Mek101 commented Apr 5, 2022

The flatpak's name is determinated by the id field, so we should be able to just change the capitalization and it should be fine

3v1n0 added a commit to 3v1n0/org.gtk.Gtk3theme.Yaru-Red-dark that referenced this issue Apr 5, 2022
3v1n0 added a commit to 3v1n0/org.gtk.Gtk3theme.Yaru-Red-dark that referenced this issue Apr 5, 2022
@Mek101
Copy link
Collaborator

Mek101 commented Apr 5, 2022

The yaru colors are bark, sage, olive, viridian, prussiangreen, blue, purple, magenta and red right?
https://github.com/ubuntu/yaru/blob/master/common/accent-colors.scss.in

@Mek101
Copy link
Collaborator

Mek101 commented Apr 5, 2022

The flatpak's name is determinated by the id field, so we should be able to just change the capitalization and it should be fine

Although this would break compatibility with Focal Fossa users still using Yaru-Colors

@santiagofn
Copy link

I've tried other colors (like Yaru-olive-dark) and the same thing happens there: differente case and lack of support for accent colors.
Seems like #1 (comment) should be applied to all the variants.

@joenepraat
Copy link

Any update? Purple Dark is my favorite theme, but some apps are displayed as the light default. The Prussian Green Dark is (for example) displayed like it should on these apps.

@amardhruva
Copy link

Purple Light User here. I would love to get my flatpak apps themed.
Btw is there something blocking from creating two repos one with legacy support and one with lowercase new themes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants