Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily revert to p7zip 17.04 #82

Merged
merged 1 commit into from Apr 2, 2024
Merged

Temporarily revert to p7zip 17.04 #82

merged 1 commit into from Apr 2, 2024

Conversation

travier
Copy link
Member

@travier travier commented Mar 31, 2024

See: #81

This reverts commit 7272555.

@flathubbot
Copy link
Contributor

Started test build 111115

@flathubbot
Copy link
Contributor

Build 111115 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/93930/org.kde.ark.flatpakref

@RacerBG
Copy link

RacerBG commented Mar 31, 2024

@travier The test build from above works as expected - the error is gone it's good for merging. Thank you!

Now the question is why but the answer probably will be for another PR.

@Erick555
Copy link
Contributor

The changelog is quite tiny so my guess is dropping the patches may cause the issue. Why were they dropped?

BTW: the p7zip-project/p7zip seems to be the main repo now so maybe keep it as source.

@travier
Copy link
Member Author

travier commented Apr 1, 2024

OK, let's try to sync with the patches used in the Arch Linux package.

@travier
Copy link
Member Author

travier commented Apr 1, 2024

@travier travier changed the title Revert "Update p7zip to 17.05" Sync with p7zip patches from Arch Linux Apr 1, 2024
@flathubbot
Copy link
Contributor

Started test build 111400

@Erick555
Copy link
Contributor

Erick555 commented Apr 1, 2024

I've synced this with the patches from https://gitlab.archlinux.org/archlinux/packaging/packages/p7zip/-/blob/main/PKGBUILD?ref_type=heads

note that Arch reverts those patches (they're part of release), not applies them.

The issue they mention is still opened and the last comment includes proposed fix but it seems nothing was done with it yet.

@travier
Copy link
Member Author

travier commented Apr 1, 2024

Ah, right.

travier added a commit that referenced this pull request Apr 1, 2024
Update to new project origin but do not update to 17.05 yet.

See: #81
See: #82

This reverts commit 7272555.
@flathubbot
Copy link
Contributor

Started test build 111410

@travier travier changed the title Sync with p7zip patches from Arch Linux Temporarily revert to p7zip 17.04 Apr 1, 2024
@Erick555
Copy link
Contributor

Erick555 commented Apr 1, 2024

I think you need also comment out x-checker-data otherwise bot will try to update it constantly.

Update to new project origin but do not update to 17.05 yet.

See: #81
See: #82

This reverts commit 7272555.
@flathubbot
Copy link
Contributor

Started test build 111416

@flathubbot
Copy link
Contributor

Build 111410 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/94227/org.kde.ark.flatpakref

@travier
Copy link
Member Author

travier commented Apr 1, 2024

I can create and open 7zip files with this one.

@RacerBG
Copy link

RacerBG commented Apr 1, 2024

I can create and open 7zip files with this one.

Works for me as well.

@flathubbot
Copy link
Contributor

Build 111400 failed

@flathubbot
Copy link
Contributor

Build 111416 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/94233/org.kde.ark.flatpakref

@travier travier merged commit 0ac5054 into master Apr 2, 2024
1 check passed
@travier travier deleted the revert-p7zip-update branch April 2, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants