Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 3 modules #123

Merged
merged 5 commits into from
Feb 2, 2024
Merged

Update 3 modules #123

merged 5 commits into from
Feb 2, 2024

Conversation

flathubbot
Copy link
Contributor

@flathubbot flathubbot commented Jan 24, 2024 •
edited by travier
Loading

Update 3 modules

Update r57.tar.gz to 58
Update v0.2.0.tar.gz to 0.3.0
Update v0.6.1.tar.gz to 0.7.0

Update openldap-LMDB to 0.9.32

Fixup kImageAnnotator installation

See: #122
See: https://invent.kde.org/graphics/gwenview/-/merge_requests/245
See: ksnip/kImageAnnotator#329
See: https://gitlab.archlinux.org/archlinux/packaging/packages/kimageannotator/-/commit/2c10232b81bfbf726e835fee8d04425dddd663d0

Fixup kColorPicker installation

Add AppStream metadata patch

See: https://invent.kde.org/graphics/gwenview/-/merge_requests/249

@flathubbot
Update 3 modules
8df3f28 
Update r57.tar.gz to 58
Update v0.2.0.tar.gz to 0.3.0
Update v0.6.1.tar.gz to 0.7.0
@flathubbot
Copy link
Contributor Author

Started test build 95526

@flathubbot
Copy link
Contributor Author

Build 95526 failed

@travier
Copy link
Member

travier commented Jan 25, 2024

See: #122 (comment)

@flathubbot
Copy link
Contributor Author

Started test build 96484

@travier travier mentioned this pull request Jan 29, 2024
Closed
@flathubbot
Copy link
Contributor Author

Build 96484 failed

@flathubbot
Copy link
Contributor Author

Started test build 96491

@flathubbot
Copy link
Contributor Author

Build 96491 failed

@flathubbot
Copy link
Contributor Author

Started test build 96497

@flathubbot
Copy link
Contributor Author

Build 96497 failed

Erick555
Erick555 reviewed Jan 29, 2024
View reviewed changes
org.kde.gwenview.json Outdated
@@ -257,11 +257,17 @@
"name": "kImageAnnotator",
"buildsystem": "cmake-ninja",
"builddir": true,
"post-install": [
"install -d -m 755 $FLATPAK_DEST/usr/lib/cmake/kImageAnnotator",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should drop /usr from the path

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch, my bad

@flathubbot
Copy link
Contributor Author

Started test build 96523

@flathubbot
Copy link
Contributor Author

Build 96523 failed

@travier
Copy link
Member

travier commented Jan 29, 2024 

-- Found KF5Purpose: /usr/lib/x86_64-linux-gnu/cmake/KF5Purpose/KF5PurposeConfig.cmake (found version "5.114.0")

Maybe it's still not the right path?

@Erick555
Copy link
Contributor

I think the path may work since the error is differrnt this time: now it can't find kcolorpicker (previously it was kimageannotator). The former has exact same regression and needs same fix.

@travier
Copy link
Member

travier commented Jan 30, 2024

Oh indeed! Good catch!

@flathubbot
Copy link
Contributor Author

Started test build 96709

@flathubbot
Copy link
Contributor Author

Build 96709 failed

@flathubbot
Copy link
Contributor Author

Started test build 96711

@flathubbot
Copy link
Contributor Author

Started test build 96712

@flathubbot
Copy link
Contributor Author

Build 96711 was cancelled

@flathubbot
Copy link
Contributor Author

Build 96712 failed

@travier
Copy link
Member

travier commented Jan 30, 2024

We're getting there!

{
    "errors": [
        "appstream-missing-developer-name"
    ],
    "warnings": [
        "appstream-screenshot-missing-caption"
    ]
}

@flathubbot
Copy link
Contributor Author

Started test build 96715

@travier
Copy link
Member

travier commented Jan 30, 2024

https://invent.kde.org/graphics/gwenview/-/merge_requests/249

@flathubbot
Copy link
Contributor Author

Build 96715 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/79474/org.kde.gwenview.flatpakref

kdesysadmin pushed a commit to KDE/gwenview that referenced this pull request Feb 2, 2024
@travier
org.kde.gwenview.appdata: Add developer_name & update caption
d73c088 
Fixes the following lint errors for Flathub:
```
{
    "errors": [
        "appstream-missing-developer-name"
    ],
    "warnings": [
        "appstream-screenshot-missing-caption"
    ]
}
```

See: flathub/org.kde.gwenview#123
See: flathub-infra/flatpak-builder-lint#274
See: https://freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer
See: https://freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer_name
@flathubbot
Copy link
Contributor Author

Started test build 97417

@flathubbot
Copy link
Contributor Author

Build 97417 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/80193/org.kde.gwenview.flatpakref

@travier travier merged commit 7a11851 into master Feb 2, 2024
1 check passed
@travier travier deleted the update-d6b8c33 branch February 2, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erick555 Erick555 Erick555 left review comments

@travier travier travier left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flathubbot @travier @Erick555