Update cmake-3.28.1.tar.gz to 3.28.2

[flathubbot]

🤖 This pull request was automatically generated by flathub-infra/flatpak-external-data-checker. Please open an issue if you have any questions or complaints. 🤖

[flathubbot]

Started test build 96636

[flathubbot]

Build 96636 failed

[bbhtt]

Looks like the icon was always wrong?

[travier]

{
    "errors": [
        "appstream-missing-developer-name",
        "desktop-file-icon-key-wrong-value"
    ],
    "warnings": [
        "appstream-summary-too-long",
        "appstream-screenshot-missing-caption",
        "finish-args-contains-both-x11-and-wayland"
    ]
}

[flathubbot]

Started test build 96721

[flathubbot]

Build 96721 failed

[flathubbot]

Started test build 96731

[flathubbot]

Build 96731 failed

[travier]

{
    "errors": [
        "desktop-file-icon-key-wrong-value",
        "appstream-failed-validation"
    ],
    "warnings": [
        "appstream-summary-too-long",
        "appstream-screenshot-missing-caption"
    ],
    "appstream": [
        "style-invalid         : <caption> is too long [Main KDevelop window with the code view, terminal integration at the bottom, project files on the left];longest allowed is 100 chars"
    ]
}

One down, one new :/

[bbhtt]

One down, one new :/

You have to fix the desktop file too btw: desktop-file-icon-key-wrong-value Feel free to ping me if you need any help on this or any other apps.

[travier]

I don't understand exactly what I need to fix. Help or pointers appreciated if you know where to look.

[flathubbot]

Started test build 96741

[bbhtt]

I don't understand exactly what I need to fix. Help or pointers appreciated if you know where to look.

The icon name in the desktop file is not a value flatpak exports, #171 (comment)

It should be a value flatpak exports like Icon=$FLATPAK_ID or combinations mentioned here https://docs.flathub.org/docs/for-app-authors/linter#desktop-file-icon-key-wrong-value

Flatpak won't export an icon that doesn't match the pattern described. So kdevelop won't be exported by flatpak as a result, the desktop file shows up without any icon on shell/overview/launchers etc.

[bbhtt]

Only the main desktop file ie. $FLATPAK_ID.desktop is checked so I guess it is this one https://github.com/KDE/kdevelop/blob/9d98eb9ed94b838ccbccc073ad4224c15e56e707/app/org.kde.kdevelop.desktop#L5

You can use something like desktop-file-edit --set-key="Icon" --set-value="${FLATPAK_ID}" "${FLATPAK_DEST}/share/applications/${FLATPAK_ID}.desktop" in a post-install command/or a patch or patch it upstream whichever is preferred.

[bbhtt]

Actually looks like the icons are also named wrong, so no icons are being exported too. You have to add a rename-icon: kdevelop too in the top.

[travier]

Hum, doesn't this mean that we have to rename the icon as well? Maybe with https://docs.flatpak.org/en/latest/manifests.html#file-renaming ?

[bbhtt]

Hum, doesn't this mean that we have to rename the icon as well? Maybe with https://docs.flatpak.org/en/latest/manifests.html#file-renaming ?

Yep just said that

[travier]

Oh indeed, my bad. Thanks

[flathubbot]

Started test build 96744

[flathubbot]

Build 96741 was cancelled

[travier]

error: /srv/buildbot/worker/build-x86_64/build/builddir/export/share/icons/hicolor/1024x1024/apps/org.kde.kdevelop.png is not a valid icon: Image too large (1024x1024). Max. size 512x512

[flathubbot]

Build 96744 was cancelled

[flathubbot]

Started test build 96747

[flathubbot]

Build 96747 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/79506/org.kde.kdevelop.flatpakref

[travier]

🎉 Thanks @bbhtt !

[bbhtt]

Thanks, it now correctly appears with the icon:

[travier]

Let's hold until we have an agreement about the developer name discussion and then I'll merge all the updates.

[travier]

bot, build

[flathubbot]

Queued test build for org.kde.kdevelop.

[flathubbot]

Started test build 97427

[flathubbot]

Build 97427 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/80203/org.kde.kdevelop.flatpakref