bundle Qt

[eszlari]

closes #25

[flathubbot]

Started test build 29464

[flathubbot]

Build 29464 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/28379/org.kde.krita.flatpakref

[dimula73]

Could you help me with testing this package?

> flatpak install --user https://dl.flathub.org/build-repo/28379/org.kde.krita.flatpakref
error: The application org.kde.krita/x86_64/test requires the runtime org.freedesktop.Platform/x86_64/20.08 which was not found

Should I add more remotes?

> flatpak remotes
Name                 Options          
flathub              system           
org.kde.krita-origin user,no-enumerate

[cho2]

@dimula73 please try

flatpak install --user flathub org.freedesktoorg.freedesktop.Platform//20.08
flatpak install --user https://dl.flathub.org/build-repo/28379/org.kde.krita.flatpakref

[dimula73]

The original bug seem to be fixed in this package. Though there are two issues:

1. [minor] With this change there is not 'breeze' support built it. It is officially not supported by Krita (due to bugs), but with previous packaging type people could override it with QT_STYLE_OVERRIDE. Since it has never been officially supported we can just ignore that :)

2. [blocking] For some reason Krita has Preferences->Global->Miscellaneous->"Enable native file dialogs" enabled by default. It makes File->Open menu action do nothing. Even though in normal Krita build this option is disabled by this code:

   if (qgetenv("XDG_CURRENT_DESKTOP") == "KDE") {
       dontUseNative = false;
   }
   

   NOTE: in the previous builds this option has also bee enabled, but KDE's file dialogs worked fine. Now they don't.

[dimula73]

Btw, thank you for your help, @cho2! The problem was in --user switch. It seem to have blocked access to the system-wide flathub repository.

[eszlari]

https://bugs.kde.org/show_bug.cgi?id=427390

It seem to have blocked access to the system-wide flathub repository.

--system and --user installations are always separate

[tsdgeos]

2. [blocking] For some reason Krita has Preferences->Global->Miscellaneous->"Enable native file dialogs" enabled by default. It makes File->Open menu action do nothing. Even though in normal Krita build this option is disabled by this code:
   ```
   if (qgetenv("XDG_CURRENT_DESKTOP") == "KDE") {
       dontUseNative = false;
   }
   ```

You don't get a dialog in process with flatpak, you ask for a file and the file portal takes care of showing the dialog and giving you back a a file.

For some reason the portal is not liking the request this krita is making, see http://paste.debian.net/1166148/

I wonder if maybe the Qt 5.12 portal doesn't know how to talk to a modern Plasma? @grulja any idea?

[grulja]

2. [blocking] For some reason Krita has Preferences->Global->Miscellaneous->"Enable native file dialogs" enabled by default. It makes File->Open menu action do nothing. Even though in normal Krita build this option is disabled by this code:

if (qgetenv("XDG_CURRENT_DESKTOP") == "KDE") {
dontUseNative = false;
}

You don't get a dialog in process with flatpak, you ask for a file and the file portal takes care of showing the dialog and giving you back a a file.

For some reason the portal is not liking the request this krita is making, see http://paste.debian.net/1166148/

I wonder if maybe the Qt 5.12 portal doesn't know how to talk to a modern Plasma? @grulja any idea?

This is because Krita sends an empty filter.

It can be fixed on Krita side, but I submitted a fix to Qt: https://codereview.qt-project.org/c/qt/qtbase/+/316508

[dimula73]

Can it be that image/jp2 mimetype is not available on the flatpak image for some reason? It looks as if the json section for jp2 file format is generated from a wrongly split string.

[tsdgeos]

@eszlari can you add Jan's patch to the patches of Qt used for this?

[flathubbot]

Started test build 29717

[flathubbot]

Build 29717 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/28619/org.kde.krita.flatpakref

[dimula73]

Hi, @eszlari!

The new package seem to work fine :) I could only find one problem: there are very few application languages available, but that is not a regression. Languages are also not available in the old package.

[Siosm]

I could only find one problem: there are very few application languages available, but that is not a regression. Languages are also not available in the old package.

Can you file that as another issue so that it can be properly investigated? Thanks

[dimula73]

Hi, @Siosm!

Can you file that as another issue so that it can be properly investigated? Thanks

Done: #27

PS:
This MR looks to work correctly

[tsdgeos]

Ok, so i'd say let's merge this?

Let's hope Krita's technical debt doesn't become unsurmountable in the future.

[flathubbot]

Started test build 29790

[flathubbot]

Build 29790 was cancelled