Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Activate Python scripting #28

Merged
merged 3 commits into from
May 21, 2020
Merged

Activate Python scripting #28

merged 3 commits into from
May 21, 2020

Conversation

jmaibaum
Copy link
Collaborator

@jmaibaum jmaibaum commented Feb 4, 2020

This PR activates Python 3 scripting, using wxPython Phoenix.

Note that this effectively also switches from wxWidgets 3.1.2 to the wxWidgets bundled with wxPython Phoenix 4.0.7.post2 as recommended by the wxPython docs. The bundled wxWidgets calls itself version 3.0.5.

@flathubbot
Copy link

Started test build 14700

@jmaibaum jmaibaum mentioned this pull request Feb 4, 2020
@flathubbot
Copy link

Build 14700 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/14031/org.kicad_pcb.KiCad.flatpakref

@flathubbot
Copy link

Started test build 15519

@flathubbot
Copy link

Build 15519 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/14829/org.kicad_pcb.KiCad.flatpakref

@jmaibaum
Copy link
Collaborator Author

jmaibaum commented May 3, 2020

@Aydan It will be merged once one of the flathub maintainers finds time to review (and approve) these changes. It is out of my control, I am just proposing this change to the best of my knowledge.

@jmaibaum
Copy link
Collaborator Author

jmaibaum commented May 3, 2020

A quick progress report: I have tried to build against the newly released wxPython 4.1.0/wxWidgets 3.1.4, but apparently upstream KiCad is having an issue with the recent privateization of the wxPaintEvent constructor in the bundled wxWidgets version (see https://gitlab.com/kicad/code/kicad/-/issues/4168).

So, if this PR is intended to be merged before KiCad 5.1.7 is going to be out (might be quite a few months from now, 5.1.6 is still not released), it seems that we need to be sticking to wxPython 4.0.7.post2 as per this PR.

@flathubbot
Copy link

Started test build 20305

@flathubbot
Copy link

Build 20305 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/19474/org.kicad_pcb.KiCad.flatpakref

Had to switch KiCad's buildsystem from cmake-ninja to plain cmake,
because of https://gitlab.com/kicad/code/kicad/issues/2905. This can be
revisited with KiCad 6.0.0.

Closes #15
@flathubbot
Copy link

Started test build 20315

@flathubbot
Copy link

Build 20315 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/19482/org.kicad_pcb.KiCad.flatpakref

@flathubbot
Copy link

Started test build 20410

@flathubbot
Copy link

Build 20410 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/19570/org.kicad_pcb.KiCad.flatpakref

@jmaibaum jmaibaum merged commit 4dce26f into flathub:master May 21, 2020
@jmaibaum jmaibaum deleted the python-scripting branch May 21, 2020 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants