Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Both libgcc_s.so.1 and libstdc++.so.6 have evolved (backwards-compatibly) from GCC 6 (whose libraries are included in the org.gnome.Platform/3.24 runtime) to 7 (<https://gcc.gnu.org/onlinedocs/gcc-7.3.0/libstdc++/manual/manual/abi.html>), so there is a chance that any of the LO binaries might use new symbols from the updated libs. The wildcard when copying libstdc++.so.6* is so that /app/lib/libstdc++.so.6.0.24-gdb.py will be included, in case that's useful for debugging. The build-time LD_LIBRARY_PATH is in case any of the binaries run during the build (e.g., tools and test code) might use new symbols from the updated libs.
...instead of `cp -a`, which caused > cp: failed to preserve ownership for /app/lib/libstdc++.so.6: No such file or directory in aarch64 build <https://flathub.org/builds/#/builders/6/builds/1551>
1 similar comment
stbergmann added a commit that referenced this pull request
Feb 2, 2018
Turns out that building LO 6.0.0 on aarch64 against GCC 7 keeps failing systematically, with a SIGABRT during CppunitTest_svtools_graphic, see aarch64 build of <https://flathub.org/builds/#/builders/1/builds/1908> and earlier builds. (Why that is so will need investigation.) <#9> "Gcc7" had been merged to finally allow building on arm (which had always failed on GCC 6), and had been seen building fine on all four platforms, including aarch64, but still building LO 5.4.4. Building on arm has meanwhile been disabled again with 1627c48 "Revert building on arm again, lack of org.freedesktop.Sdk.Extension.openjdk9", so disable building against GCC 7 again for now, too.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.