Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Can't open any links #1

Closed
alice-mkh opened this issue Apr 1, 2018 · 21 comments
Closed

Can't open any links #1

alice-mkh opened this issue Apr 1, 2018 · 21 comments
Labels
bug Something isn't working upstream An issue with Thunderbird itself

Comments

@alice-mkh
Copy link
Contributor

alice-mkh commented Apr 1, 2018

When I click any link, Thunderbird presents an empty application selector.
2018-04-01 13-27-50

Choosing an application manually doesn't work too, since the opened file chooser is inside the sandbox.

@alice-mkh
Copy link
Contributor Author

This is presumably fixed upstream, but the patch seems to be a bit Firefox-specific.
https://bugzilla.mozilla.org/show_bug.cgi?id=1411579

@nedrichards
Copy link
Member

I forget if the xdg-open shim is helpful here, or if that's in the sandbox already. We had that one in the endless version of this right @mariospr ? https://github.com/mattdangerw/flatpak-xdg-open-shim

@mariospr
Copy link
Collaborator

mariospr commented Apr 1, 2018

@nedrichards It shouldn't be necessary now, since the freedesktop runtime already includes a flatpak-specific version of xdg-utils that communicates with the portals: https://github.com/flatpak/flatpak-xdg-utils

The problem here is similar to the one solved by Firefox in [1], and would need a similar patch in Thunderbird to get seamless integration with the portals, I'm afraid. In the meantime, what you can do is to click on the "Choose" button of the dialog shown in #1 (comment) and select /usr/bin/xdg-open, that would redirect the links through the OpenURI portal.

Thus, unless I'm missing something, this is really a bug in Thunderbird, not in flatpak or the portals.

[1] https://hg.mozilla.org/integration/autoland/rev/317b11e45292

@alice-mkh
Copy link
Contributor Author

Yes, the workaround with /usr/bin/xdg-open works fine with a browser on host. There's still a problem when both Thunderbird and browser are flatpaks, but that's another issue.

@AdrianKoshka AdrianKoshka added the bug Something isn't working label Apr 1, 2018
@AdrianKoshka AdrianKoshka added the upstream An issue with Thunderbird itself label Apr 29, 2018
@AdrianKoshka
Copy link
Collaborator

So, just to confirm, this is a Thunderbird issue, and not a flatpak issue, and needs to be fixed upstream?

@mariospr
Copy link
Collaborator

mariospr commented Apr 29, 2018 via email

@therealrobster
Copy link

Just an echo to say I also am having this issue.
Latest flatpak on Ubuntu 18.04.

@mariospr
Copy link
Collaborator

mariospr commented May 2, 2018 via email

@ovari
Copy link
Contributor

ovari commented Jun 27, 2018

[flatpak] "Open with" list is empty and and application chooser is empty
Product: Thunderbird
https://bugzilla.mozilla.org/show_bug.cgi?id=1471420

@ryanleesipes
Copy link

Looks like we could use some guidance on implementation as per this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1290670

@mariospr
Copy link
Collaborator

mariospr commented Jul 2, 2018

@ryanleesipes A specific question would help :-)

@AdrianKoshka
Copy link
Collaborator

Any update on this one? v60 released and I skimmed the release notes, didn't see anything about this.

@ovari
Copy link
Contributor

ovari commented Aug 10, 2018

@ovari
Copy link
Contributor

ovari commented Oct 17, 2018

Does this look like this issue will be fixed in a Thunderbird flatpak based on the next Thunderbird ESR, i.e. Thunderbird 68 and later?
https://bugzilla.mozilla.org/show_bug.cgi?id=1490186#c19

@mariospr
Copy link
Collaborator

Does this look like this issue will be fixed in a Thunderbird flatpak based on the next Thunderbird ESR, i.e. Thunderbird 68 and later?
https://bugzilla.mozilla.org/show_bug.cgi?id=1490186#c19

Yes, it looks like that would be exactly what's needed here, thus removing the need for the hack mentioned above.

@ovari
Copy link
Contributor

ovari commented Apr 30, 2019

In the event that this can help the Thunderbird Flatpak version, LibreOffice code to Support "Preview in Web Browser" in Flatpak mode
https://gerrit.libreoffice.org/#/c/71570/1

@Peque
Copy link

Peque commented Aug 28, 2019

It seems Thunderbird 68 is available now. 😊

@Erick555
Copy link
Collaborator

Yes, I'll prepare test PR with it soon. I consider waiting for 68.1 before updating main app as .0 releases usually aren't completely stable.

@ovari
Copy link
Contributor

ovari commented Aug 28, 2019

@Erick555 Suggestion:

  1. Release the Thunderbird 68.0 Flatpak version asap here at https://github.com/flathub/org.mozilla.Thunderbird/. This will enable people to test Thunderbird 68.0 for Flatpak. Feedback can be given as shown in the quote (with links) below.
  2. Release Thunderbird Thunderbird Extended Support Release (ESR) versions which automatically update at https://github.com/flathub/net.thunderbird.Thunderbird/. Automatic updates would be version Thunderbird ESR 68.1+ (see quote below).
  3. Release Thunderbird Beta versions at https://github.com/flathub/org.mozilla.Thunderbird/. This would occur after 68.1 is released.

Other options for Thunderbird Flatpak repository locations are:
Thunderbird ESR: https://github.com/flathub/net.thunderbird.ThunderbirdESR/
Thunderbird Beta: https://github.com/flathub/net.thunderbird.ThunderbirdBeta/

What do you think?

Thank you

Version 68.0 is now released after being in beta for many months with about 70,000 users.

Please note it is released but NOT available for automatic or manual update. Similar to version 60.0, 68.0's initial rollout is only available as a manual download from thunderbird.net which you then install. After we receive broader feedback and provide updates to 68.0, then normal update mechanisms will be enabled.

We encourage you to report problems, give feedback, and ask questions in the following ways:

  • If you have a support issue, a question or need advice please post at support with a clear description, and mention your version.
  • If a problem reproduces in safe mode please file a bug report in bugzilla, state your version, steps to reproduce, and whether problem happens in the prior version.
  • If the problem does not reproduce in safe mode, please determine the cause and add information to the etherpad, whether it be an add-on, configuration or some other issue. Also you should report add-on issues to the author via the add-on's support website or email, found on the add-ons website. (do not report problems by posting a review)
  • If Thunderbird crashes please file a bug report using Help > Troubleshooting > click the crash ID to view the crash report page > click the bugzilla tab, click the "Thunderbird" link and include in your bug report steps to reproduce, because we are not able to see comments submitted in your crash report.
  • If you encounter broken with the add-ons website, please report it at https://github.com/thundernest/addons-server or in the etherpad.

You can follow reported bugs and other issues as follows:

  • An etherpad and please comment in the pad (no login required) if you encounter an issue not reported in Thunderbird support or bugzilla, especially add-on issues.
  • A partial list of bugs found during version 68 testing - follow activity via the link, or subscribe to the bug with your bugzilla account.

Thank you for helping make Thunderbird 68 better!

NOTE: win64 is not yet officially released, but should be soon

@Erick555
Copy link
Collaborator

@ovari

Release the Thunderbird 68.0 Flatpak version asap here at https://github.com/flathub/org.mozilla.Thunderbird/. This will enable people to test Thunderbird 68.0 for Flatpak. Feedback can be given as shown in the quote (with links) below.

I'll consider this after I successfully build and test it.

Release Thunderbird Thunderbird Extended Support Release (ESR) versions which automatically update at https://github.com/flathub/net.thunderbird.Thunderbird/. Automatic updates would be version Thunderbird ESR 68.1+ (see quote below).

There is no such thing like automatic self updates in flathub. Each update have to be done by maintainer. I don't plan to publish ESR, also it seems enterprise focused so flathub doesn't seem the place for it at all.

Release Thunderbird Beta versions at https://github.com/flathub/org.mozilla.Thunderbird/. This would occur after 68.1 is released.

Flathub supports beta channels under the same app-id so something like https://github.com/flathub/net.thunderbird.ThunderbirdBeta is not needed. I don't plan to add beta channel here though, at least not now.

@Erick555
Copy link
Collaborator

This is fixed by #73

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working upstream An issue with Thunderbird itself
Projects
None yet
Development

No branches or pull requests

9 participants