Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Freedesktop SDK to 23.08 #516

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

genodeftest
Copy link
Contributor

No description provided.

@flathubbot
Copy link
Contributor

Started test build 67985

@flathubbot
Copy link
Contributor

Build 67985 failed

@genodeftest
Copy link
Contributor Author

genodeftest commented Sep 23, 2023

Depends on (blocked by) flathub/org.electronjs.Electron2.BaseApp#43, as Electron is currently built against Freedesktop SDK 22.08 and you cannot have Signal depend on Electron with both depending on different versions of the Freedesktop SDK.

@genodeftest genodeftest reopened this Sep 24, 2023
@flathubbot
Copy link
Contributor

Started test build 68394

@flathubbot
Copy link
Contributor

Build 68394 failed

@bbhtt
Copy link
Contributor

bbhtt commented Sep 25, 2023

23.08 baseapp is out now.

Can you check if desktop notifications work without --talk-name=org.freedesktop.Notifications?

The 23.08 baseapp includes libnotify 0.8.2 which should not require that hole.

@flathubbot
Copy link
Contributor

Started test build 69405

@flathubbot
Copy link
Contributor

Build 69405 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/52059/org.signal.Signal.flatpakref

@bermeitinger-b bermeitinger-b marked this pull request as ready for review September 28, 2023 10:59
@bermeitinger-b bermeitinger-b merged commit 2effb02 into flathub:master Sep 28, 2023
1 check passed
@genodeftest genodeftest deleted the patch-1 branch October 3, 2023 14:43
@genodeftest
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants