Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 0.1.0 #8

Merged
merged 1 commit into from Mar 20, 2024
Merged

Update to 0.1.0 #8

merged 1 commit into from Mar 20, 2024

Conversation

rmader
Copy link
Contributor

@rmader rmader commented Mar 15, 2024

Additional changes:

  • Update to Gnome 46 runtime with GTK 4.14, needed for Wayland passtrough.
  • Update to Gst 1.24.1 for Wayland passthrough on VA-API and V4L2
    stateless.
  • Re-enable Gst VP9 V4L2 stateless decoder, which got improved a lot.
  • Add "Downloads" to accessable folders
  • Make access to "Videos" and "Downloads" read-only
  • Add X11 support because we have to...

@flathubbot
Copy link

Started test build 107196

@flathubbot
Copy link

Build 107196 failed

@flathubbot
Copy link

Started test build 107517

@flathubbot
Copy link

Build 107517 failed

@rmader rmader marked this pull request as ready for review March 20, 2024 12:08
@flathubbot
Copy link

Started test build 108224

@flathubbot
Copy link

Build 108224 failed

@rmader
Copy link
Contributor Author

rmader commented Mar 20, 2024

Hm, the build now complains about finish-args-only-wayland - so do we have to add the x11-fallback?

Additional changes:
 - Update to Gnome 46 runtime with GTK 4.14, needed for Wayland passtrough.
 - Update to Gst 1.24.1 for Wayland passthrough on VA-API and V4L2
   stateless.
 - Re-enable Gst VP9 V4L2 stateless decoder, which got improved a lot.
 - Add "Downloads" to accessable folders
 - Make access to "Videos" and "Downloads" read-only
 - Add X11 support because we have to...
@flathubbot
Copy link

Started test build 108226

@flathubbot
Copy link

Build 108226 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/91046/org.sigxcpu.Livi.flatpakref

@rmader
Copy link
Contributor Author

rmader commented Mar 20, 2024

Tested both builds - AMD64 and ARM64 - and they seem to work great!

X11 doesn't work of course and that's a app choice. So I really don't understand why we are not allowed to put in the manifest. But well, their call.

So this is ready to merge I think \o/

(unless you want to add https://gitlab.gnome.org/guidog/livi/-/merge_requests/42 ?)

@agx
Copy link
Collaborator

agx commented Mar 20, 2024

@rmader you mentioned brand colors. Do you want to add those as well?

@agx
Copy link
Collaborator

agx commented Mar 20, 2024

Tested both builds - AMD64 and ARM64 - and they seem to work great!

X11 doesn't work of course and that's a app choice. So I really don't understand why we are not allowed to put in the manifest. But well, their call.

So this is ready to merge I think \o/

(unless you want to add https://gitlab.gnome.org/guidog/livi/-/merge_requests/42 ?)

Thanks for looking into this! I think we can go without that MR and do that for 0.1.1.

@rmader
Copy link
Contributor Author

rmader commented Mar 20, 2024

@rmader you mentioned brand colors. Do you want to add those as well?

I had a chat with Tobias about that and we figured that in order to do it right we should consider (slightly) changing the icon and screenshots etc. as well - and that would require a proper session with some hours time, including feedback rounds with you. So we didn't get to that yet :/

@rmader
Copy link
Contributor Author

rmader commented Mar 20, 2024

Thanks for looking into this! I think we can go without that MR and do that for 0.1.1.

Agreed - then lets go?

@rmader
Copy link
Contributor Author

rmader commented Mar 20, 2024

@agx just so you know: on GLES2 devices like the librem5 you'll likely still see occasional glitches with parts of the window being black. That got fixed in https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7053 and will thus disappear once the runtime ships the next GTK dot release.

@agx
Copy link
Collaborator

agx commented Mar 20, 2024

@agx just so you know: on GLES2 devices like the librem5 you'll likely still see occasional glitches with parts of the window being black. That got fixed in https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7053 and will thus disappear once the runtime ships the next GTK dot release.

I think we can live with that until then in favor of giving the whole offload stack more testing. Thanks!

@agx agx merged commit efeeb20 into flathub:master Mar 20, 2024
1 check passed
@@ -98,8 +99,8 @@
{
"type" : "git",
"url" : "https://gitlab.gnome.org/guidog/livi",
"tag" : "v0.0.6",
"commit" : "8c73da4959db7e5291a64fda108ff1e26c0eac35"
"tage" : "0.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I made a typo and changed tag to tage - but shouldn't matter as the commit is still correct. But should be fixed on the next update :P

@@ -76,8 +77,8 @@
{
"type": "git",
"url": "https://gitlab.freedesktop.org/gstreamer/gstreamer.git",
"tag": "1.22.8",
"commit": "4af14db10e8355f980bbf79733af004e59d255fc",
"branch": "1.24",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEVER use branches. That why the build failed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, thanks! Will open a fix-up MR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #9

@rmader rmader deleted the update-0.1.0 branch March 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants