Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pyqt to 5.15 #9

Merged
merged 11 commits into from Nov 26, 2021
Merged

update pyqt to 5.15 #9

merged 11 commits into from Nov 26, 2021

Conversation

Bleuzen
Copy link
Collaborator

@Bleuzen Bleuzen commented Nov 24, 2021

No description provided.

@flathubbot
Copy link
Contributor

Started test build 68224

@flathubbot
Copy link
Contributor

Build 68224 failed

@Bleuzen
Copy link
Collaborator Author

Bleuzen commented Nov 24, 2021

Don't know why it failed yet. This error message at the end of the log doesn't look really useful to me.
@hfiguiere @tinywrkb @falkTX any idea?

studio.kx.carla.json Outdated Show resolved Hide resolved
@hfiguiere
Copy link
Contributor

Don't know why it failed yet. This error message at the end of the log doesn't look really useful to me. @hfiguiere @tinywrkb @falkTX any idea?

I see:

/usr/bin/python3: No module named PyQt5.pyrcc_main

Which seems to trigger a fatal build error.

Co-authored-by: Hubert Figuière <hub@figuiere.net>
@flathubbot
Copy link
Contributor

Started test build 68230

@flathubbot
Copy link
Contributor

Build 68230 failed

@hfiguiere
Copy link
Contributor

I think if you set the permission to executable and update the commit it's ok. or can call it with sh.

@flathubbot
Copy link
Contributor

Started test build 68234

@flathubbot
Copy link
Contributor

Build 68234 failed

@Bleuzen Bleuzen mentioned this pull request Nov 24, 2021
@flathubbot
Copy link
Contributor

Started test build 68258

@flathubbot
Copy link
Contributor

Build 68258 failed

@flathubbot
Copy link
Contributor

Started test build 68262

@flathubbot
Copy link
Contributor

Build 68262 failed

@flathubbot
Copy link
Contributor

Started test build 68263

@flathubbot
Copy link
Contributor

Build 68263 failed

@Bleuzen
Copy link
Collaborator Author

Bleuzen commented Nov 25, 2021

/usr/bin/python3: No module named PyQt5.pyrcc_main

Hm, some lines above:

/app/bin/pyrcc5 ../../resources/resources.qrc -o resources_rc.py

and below:

make[1]: *** [Makefile:111: resources_rc.py] Error 1

seems that resource handling doesn't work.
Maybe pyrcc5 doesn't find PyQt5 because in the flatpak it is installed in a different prefix compared to the default one.

I tried to get it to find our PyQt5 install in the flatpak by setting the PYTHONPATH env var, but it still fails.
Idk. anymore :/

@flathubbot
Copy link
Contributor

Started test build 68589

@Bleuzen
Copy link
Collaborator Author

Bleuzen commented Nov 26, 2021

I think I got it to build now. Damn, this took me way too long to figure out.
Turns out that pyrcc is not fully built be default.

From docs:

--no-tools
    New in version 5.3.
    The pyuic5, pyrcc5 and pylupdate5 tools will not be built.

So I did not pass the --no-tools build option for PyQt5 and assumed it builds pyrcc. But turns out it doesn't really.
Only thing it does is install a wrapper script for it, but not pyrcc itself. We have to explicitly build the native lib too with another build option, which I had to guess:

--enable=pyrcc

It is such a great documentation and build system ahhh tf.
Anyway, it builds now.

But don't get too excited yet. Because it doesn't run xD

@flathubbot
Copy link
Contributor

Build 68589 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66425/studio.kx.carla.flatpakref

@flathubbot
Copy link
Contributor

Started test build 68591

@flathubbot
Copy link
Contributor

Build 68591 failed

@falkTX
Copy link
Collaborator

falkTX commented Nov 26, 2021

It is such a great documentation and build system ahhh tf.

ah I know the pain.. pyqt build system is weird, also keeps changing on a regular basis.

@Bleuzen
Copy link
Collaborator Author

Bleuzen commented Nov 26, 2021

bot, build studio.kx.carla

@flathubbot
Copy link
Contributor

Queued test build for studio.kx.carla.

@flathubbot
Copy link
Contributor

Started test build 68593

@Bleuzen
Copy link
Collaborator Author

Bleuzen commented Nov 26, 2021

@falkTX Can you review the Qt modules?
They are defined in this file:
https://github.com/flathub/studio.kx.carla/blob/pyqt-update/pyqt-build

I'm not sure which of those Carla really uses. Thinking about removing for example QtDBus and QtMultimedia.

@flathubbot
Copy link
Contributor

Started test build 68594

@flathubbot
Copy link
Contributor

Build 68593 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66428/studio.kx.carla.flatpakref

@flathubbot
Copy link
Contributor

Build 68594 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66429/studio.kx.carla.flatpakref

@Bleuzen
Copy link
Collaborator Author

Bleuzen commented Nov 26, 2021

Latest build works :)

@flathubbot
Copy link
Contributor

Started test build 68595

@flathubbot
Copy link
Contributor

Build 68595 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66430/studio.kx.carla.flatpakref

@falkTX
Copy link
Collaborator

falkTX commented Nov 26, 2021

@falkTX Can you review the Qt modules?

they look correct as of now, only QtOpenGL missing (though this one is optional, can be turned off if it is troublesome)

@flathubbot
Copy link
Contributor

Started test build 68601

@flathubbot
Copy link
Contributor

Build 68601 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66436/studio.kx.carla.flatpakref

@Bleuzen Bleuzen merged commit 4a061ed into master Nov 26, 2021
@Bleuzen Bleuzen deleted the pyqt-update branch November 26, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants