Disable request.jar

[kesla]

Request has since 2.9.0 introduced support for cookie jars.

It means that if a Cookie-header is sent without using the cookie jar it will be overwritten by request.

Disabling the cookie jar functionality in request makes api-easy work like it used to. Tests passes when using an older version of request (2.2.9) also.

[indexzero]

@kesla Looks good. Can we make this configurable somehow?

[kesla]

@indexzero If we want to make it configurable (and we should) we probably want to use this.options as suggested in https://github.com/flatiron/api-easy/blob/master/lib/api-easy.js#L99 and use options.request to override any of request's default values.

That way you could, for example, configure api-easy to disable it cookie jar and not follow redirects like this:

suite.discuss('When using your awesome API')
       .discuss('and your awesome resource')
       .use('localhost', 8080, {
         'request': {
           'followRedirect': false,
           'jar': false
         }
       })
       .setHeader('Content-Type', 'application/json')
       .post({ test: 'data' })
         .expect(200, { ok: true })
         .expect('should respond with x-test-header', function (err, res, body) {
           assert.include(res.headers, 'x-test-header');
         })
       .export(module);

Sounds reasonable? Should I close this pull request and open a new one with the suggested api above?

[indexzero]

@kesla Yes. Sorry for the long-turn around here. Please re-open a new pull-request