Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 0.10.x support #192

Closed
julianduque opened this issue May 2, 2013 · 5 comments
Closed

Node 0.10.x support #192

julianduque opened this issue May 2, 2013 · 5 comments

Comments

@julianduque
Copy link
Contributor

No description provided.

@dcneiner
Copy link
Contributor

dcneiner commented May 2, 2013

In the package.json, vows is specified as version: "0.6.x". I installed vows 0.7.0 and all the tests ran and passed with node v0.10.3.

@julianduque
Copy link
Contributor Author

Pull Request welcome :)

@dcneiner
Copy link
Contributor

dcneiner commented May 2, 2013

@julianduque There you go! After upgrading to 0.7.x I also ran the tests against node v0.8.15 (latest version of 0.8.x I have installed) and the tests still ran fine.

julianduque added a commit that referenced this issue May 2, 2013
@julianduque
Merge pull request #193 from dcneiner/node-10-x
3746022 
Updated version of vows from 0.6.x to 0.7.x. Fixes #192
@julianduque
Copy link
Contributor Author

Thanks for your contribution!

@dcneiner
Copy link
Contributor

dcneiner commented May 2, 2013

Sure thing @julianduque – glad it was such an easy fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcneiner @julianduque