Http Router doesn't work with URL parameters

[stolsma]

When testing with: http://development:9090/test/foo?test=test the attached route function to /test/foo isn't executed. But if I change the request to http://development:9090/test/foo it is.

I debugged the code and found that the whole URL (+ the parameters after ?) is fed into the traverse function by the dispatch function. If I change that to only the part before ? then it works. Can make a patch for it but don't know if the current behavior is the correct one. If this is the correct behavior then what do I need to do to get URLs with parameters working with Director?

[pksunkara]

Go ahead and make a pull request. @indexzero, @mmalecki, can you check this?

[indexzero]

@stolsma Hmm ... right. In the tightly integrated scenario (i.e. director + union), union is already stripping these characters before it's passed to the router. I suppose we can reparse here, but it should definitely be an option or something.

[stolsma]

@indexzero Are you sure that union is stripping these characters in a integrated scenario? I'm asking this because my test implementation is using union+director and there url parameters doesn't work.... Example how I use it:

var union = require('union');
var router = require('director').http.Router().configure({async: true});

router.get(/foo/, function () {
  this.res.writeHead(200, { 'Content-Type': 'text/plain' })
  if (this.req.token) {
    this.res.end('hello ' + this.req.token.user + '\n');
  } else {
    this.res.end('hello world\n');
  }
});

var server = union.createServer({
  before: [
    function (req, res) {
      var found = router.dispatch(req, res);
      if (!found) {
        res.emit('next');
      }
    }
  ]
});

server.listen(9090);

Is there an easier way to implement my example??

[indexzero]

@stolsma Again, you seem to be right. Union is parsing them, but not stripping them.

https://github.com/flatiron/union/blob/master/lib/request-stream.js#L31-43

Your example is correct.

[stolsma]

@indexzero Thanks for the confirmation! :-)

In my opinion union must not strip anything from req.url because then we loose the original request url and thats also something I need... ;-)

[indexzero]

yeah, we should probably put the parse somewhere though so we don't have to reparse it.