Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix the scope error when using .on() in the browser #164

Merged
merged 1 commit into from

4 participants

@andyburke

This should address Issue #76 (#76)

@coen-hyde

please merge this

@pksunkara pksunkara merged commit 9f0a960 into flatiron:master

1 check passed

Details default The Travis build passed
@soundstep

I can see the change in there:
https://github.com/flatiron/director/blob/master/lib/director/router.js

But it looks like the lib hasn't been rebuilt as it is not in there:
https://github.com/flatiron/director/blob/master/build/director-1.1.8.js

Is that normal?

Romu

@pksunkara

@soundstep This will be released in director-1.1.9.js. Not before.

@soundstep

Great, thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 14, 2012
  1. @andyburke

    Fix scope in browser.

    andyburke authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  lib/director/browser.js
View
1  lib/director/browser.js
@@ -175,6 +175,7 @@ var Router = exports.Router = function (routes) {
this.params = {};
this.routes = {};
this.methods = ['on', 'once', 'after', 'before'];
+ this.scope = [];
this._methods = {};
this._insert = this.insert;
Something went wrong with that request. Please try again.