Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the scope error when using .on() in the browser #164

Merged
merged 1 commit into from Dec 6, 2012

Conversation

andyburke
Copy link
Contributor

This should address Issue #76 (#76)

@coen-hyde
Copy link
Contributor

please merge this

pksunkara added a commit that referenced this pull request Dec 6, 2012
Fix the scope error when using .on() in the browser
@pksunkara pksunkara merged commit 9f0a960 into flatiron:master Dec 6, 2012
@soundstep
Copy link

I can see the change in there:
https://github.com/flatiron/director/blob/master/lib/director/router.js

But it looks like the lib hasn't been rebuilt as it is not in there:
https://github.com/flatiron/director/blob/master/build/director-1.1.8.js

Is that normal?

Romu

@pksunkara
Copy link
Contributor

@soundstep This will be released in director-1.1.9.js. Not before.

@soundstep
Copy link

Great, thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants