New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix hash-based route match #264
Conversation
longlho
commented
Nov 4, 2014
- update dependencies
- remove query params from path
fixes #263 |
@longlho if this does not affect any other use cases, it LGTM. Could you switch to the ~ over the ^ in the dependencies so the |
yup will do :) |
@jcrugzz anything else :)? |
This LGTM. @beaugunderson this seem good to you? I havent used director client side so I just wanted to confirm there would be no other side effects. |
actually fuck it, this does look good. @longlho can you just predefine the regex near the require calls? it will make it faster because it will be precompiled instead of interpreted each time the replace is called. Last nit :) |
9804912
to
3f47e76
Compare
- update dependencies - remove query params from path - extract & declare query separator
@jcrugzz just did, squashed everything too :) The |
@longlho this was formed before browserify was a thing. I dont think @indexzero would be opposed to the idea of switching to that so we can both have a build process and the ability to be used directly in browserify. |
and thanks! |