Browser tests, fix greedy matching, default data-bind, convention and configuration #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 10, 2013 09:35
…d make specifying a general attribute to match on (map.conf.where) work. Update the tests: * Test 7 previously worked because of the greedy matching bug, changed to also show an attribute that should not match (with the same value as one that should). * Tests 12, 16 and 17 used the undocumented greedy matching to match on class names, added a Map configuration (where: 'class').
…ings and add tests. This updates flatiron#58 against latest master.
…conventions (default settings like mapping 'id', 'data-bind(-attr)' and the map.conf.where setting).
|
Is there any interest in merging this PR? Or is this project gaining no more support? |
Closed
…ssName' instead of 'class'), serverside tests (api-test.js) updated to match.
…n (could fail if attributes were undefined).
|
Closing this due to age. This project is formally deprecated. Will be adding a notice soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds all tests to browser runner:
This adds all tests in api-test.js to browser.html.
I used the browser.js script to generate the skeleton of the code, then manually copy/pasted the content of the tests (I assume it has to be done this way as the IIFEs make it imposible to introspect the original test source code). The only test that needed modifying was number 33 as that doesn't use common.createTest(). (All the new tests pass, the two of the old ones that failed are still failing.)
The second commit fixes the issue described here: #65 and updates tests accordingly.
The third commit updates #58 data-bind and data-bind-(attr).
The fourth commit fixes cases where 'data-bind' would unintentionally overwrite content in a template.
The sixth commit add the (non optional) ability to use both defined mappings and default behaviour, as referred to in #73 and #76 (I think this makes more sense than current behaviour).
PS Sorry for not using feature branches for this, but one fix led to another :)