Instantiating engines by passing the Engine constructor into resourceful.use() #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
resourceful.engines
contains a map of engine constructors, soresourceful.use()
should really take a constructor rather than an object.So you can do this:
Otherwise you'd have to instantiate the Engine then pass it in, which wouldn't fit the method any more.
Assuming this is a just a bug, so changed the validation from
'object'
to'function'
and added tests to that effect. I may be missing something though.