Fix medw loading as b'NoneType' instead of None #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I encountered a bug when running a CNMF refit after loading the CNMF object from HDF5. This was caused by
params.spatial['medw']beingb'NoneType'rather thanNone.Noneparameters are currently converted to the string 'NoneType' during saving, which is read back into Python asb'NoneType', and this should be converted back toNone, but due to the way the conditionals are structured, parameters which should be converted to tuples if not None are not converted if they equalb'NoneType'. (They are converted if they are the regular string'NoneType'.) I fixed it so that both NoneType cases are handled first, and otherwise simplified the conditional structure (but that should be the only change in behavior).Partially addresses #1264.
Type of change
Please delete options that are not relevant.
Has your PR been tested?
Yes,
caimanmanager testandcaimanmanager demotestpass.