Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saliency output format #1

Closed
mortonjt opened this issue Feb 7, 2020 · 2 comments
Closed

Saliency output format #1

mortonjt opened this issue Feb 7, 2020 · 2 comments

Comments

@mortonjt
Copy link
Collaborator

mortonjt commented Feb 7, 2020 •
edited

I'm noticing that there are pickle files that are the output of deepfri.

There are a few immediate reasons why this may not be advantageous

  1. Pickle files are specific for python - can't parse them in another language
  2. There are security issues surrounding python
  3. There are likely to be version issues that pop up due to the choice of python and numpy, where one user has numpy=1.10, but the pickle can only be read in 1.17 (these issues do actually happen).

Looking inside of the contents, it looks like this can be easily encoded as a json format, which is a more forgiving format.
@VGligorijevic
Copy link

Thank you @mortonjt ! DeepFRI now outputs files in json format.

@mortonjt
Copy link
Collaborator Author

mortonjt commented May 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mortonjt @VGligorijevic