Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage dashboard with css grid #27

Closed
wants to merge 2 commits into from
Closed

Conversation

garrettmflynn
Copy link
Collaborator

@garrettmflynn garrettmflynn commented Oct 26, 2023

This PR introduces the use of CSS Grid to handle the sizing of nav, sidebar, and main elements in the application.

At this moment, the Splitter.tsx component cannot be adjusted since this heavily relied on explicit height / width declarations—though this should be the only inconsistency.

@magland Thought I'd share this, though I'll keep it in draft mode until the former issue is resolved. Can you peruse to see if anything else looks wonky? Not all of my tables and other components are populated, which may bias my tests.

Splitter cannot be adjusted, though this should be the only inconsistency
@garrettmflynn garrettmflynn self-assigned this Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@magland
Copy link
Collaborator

magland commented Oct 26, 2023

Overall looks good. You removed W and H in TabWidget.tsx and so this is causing the page to crash for me.

TabWidget is going to be another component that you'll have trouble with in this overhaul.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@magland
Copy link
Collaborator

magland commented Oct 30, 2023

@garrettmflynn I updated this branch to reflect the new name (protocaas -> dendro).

I'm going to look into getting splitter and tab widgets to work.

@magland
Copy link
Collaborator

magland commented Oct 30, 2023

@garrettmflynn I played around with this a bit and I'm not sure how I can accomplish the nested splitter widgets without passing explicit sizes down to the child windows. The issue is that you could have splitters nested within tab widgets nested within other splitters, and it's difficult to have the flexibility of controlling the behavior. Also, there could eventually be widgets that require knowing their width/height in order to display properly. Not sure if there are mechanisms for handling this using css strategy.

@garrettmflynn
Copy link
Collaborator Author

No worries, there may be strategies—but they'll likely be equally contrived if we're trying to maintain the exact same rendering behaviors in an existing system.

You can close this PR and I'll find a simpler solution to the scroll issue. More than anything, just wanted to put these CSS strategies on your radar.

@magland magland closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants