Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels without "for" attribute #54

Closed
strouhaljan opened this issue Sep 17, 2015 · 2 comments
Closed

Labels without "for" attribute #54

strouhaljan opened this issue Sep 17, 2015 · 2 comments

Comments

@strouhaljan
Copy link

Hi guys, I had difficulties using your library when building a web app. I had no unique ID for checkboxes and radios to pair them with labels. Only solution was to generate random ID and then use it.

I've found a solution to design checkboxes and radios in your way using your library with checkboxes (radios) nested inside of a label (no "for" and "id" attribute needed). I wish to present it to others. What's the best way to do it? Should I modify your files, or create new files or just fork your whole project and make a new one?

This could be my first contribution so I am sorry I don't know exactly, how it works :-)

@coltonmccormack
Copy link

Generally the best way is to fork the project, make your alterations, commit them to your project, and then turn that commit into a pull-request for the original project (this one).

Here's a helpful guide for submitting GitHub pull-requests.

If you need more help, feel free to reply here.

@DimaSavchenko
Copy link
Contributor

Guys, thanks for your comments.
@thatguyyoulove offered the best way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants