Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop moving metadata->appdata when all runtimes support metadata #252

Open
jurf opened this issue Jan 8, 2019 · 6 comments · May be fixed by #441
Open

Stop moving metadata->appdata when all runtimes support metadata #252

jurf opened this issue Jan 8, 2019 · 6 comments · May be fixed by #441
Milestone

Comments

@jurf
Copy link
Member

jurf commented Jan 8, 2019

Flatpak-builder version

flatpak-builder 1.0.1

Description of the problem

The correct place for those files is metainfo, see flatpak/flatpak#30, but flatpak-builder moves them to appdata, leaving metainfo empty.

@alexlarsson
Copy link
Member

I know that the supposed "new" location is metainfo. However, there is no practical difference from using the two, except that "metainfo" doesn't work on runtimes that have older versions of the appstream-compose tool. So, we support apps that install in whichever directory, and then tweak this in f-b to support old runtimes.

Eventually we could change this i guess. As old runtimes are phased out.

@jurf
Copy link
Member Author

jurf commented Jan 10, 2019

OK, make sense. Maybe keep this open then though?

@alexlarsson
Copy link
Member

Sure.

@alexlarsson alexlarsson reopened this Jan 10, 2019
@alexlarsson alexlarsson changed the title Appstream files are moved from metainfo to appdata Stop moving metadata->appdata when all runtimes support metadata Jan 10, 2019
@nanonyme
Copy link
Contributor

How old is old here?

@mwleeds
Copy link
Collaborator

mwleeds commented Nov 24, 2021

Looks like the 18.08 org.freedesktop.Platform runtime, which has long been end-of-life, was built with appstream-glib 0.7.10 at the beginning of its life (a version which supported /usr/share/metainfo). So it seems clear enough time has passed that we can start putting the metainfo in the correct directory in flatpak-builder, and we especially should since Appstream 1.0 will drop support for the legacy path per discussion in flatpak/flatpak#4600.

Flatpak will need to still support apps that have metainfo in the legacy path for backwards compat, but we can export it into the new path.

@mwleeds mwleeds added this to the 1.3.1 milestone Nov 24, 2021
mwleeds added a commit that referenced this issue Dec 15, 2021
The old path will not be supported by the upcoming AppStream 1.0
release, and the new path is well supported.

Fixes #252
@mwleeds mwleeds linked a pull request Dec 15, 2021 that will close this issue
mwleeds added a commit that referenced this issue Dec 15, 2021
The old path will not be supported by the upcoming AppStream 1.0
release, and the new path is well supported.

Fixes #252
@Jehan
Copy link

Jehan commented Feb 23, 2022

For the record, it was a problem for GIMP (dev version) today. We just implemented a welcome dialog feature showing the release notes when an update (software update, not package update) happened. We are using the <release> tag contents for this, since it exists already, is widely translated already and so on. And I got the surprise when testing the generated flatpak that it failed to grab the info because it got moved to appdata/.

So anyway I am working around the issue for now, but it's not too nice that the package system moves our data like this, especially when installing it to the location recommended by specs. So I will be looking this report until it gets closed (i.e. that the file is not moved by flatpak-builder anymore) now. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants