Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new metainfo path #441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use new metainfo path #441

wants to merge 1 commit into from

Conversation

mwleeds
Copy link
Collaborator

@mwleeds mwleeds commented Dec 15, 2021

Export to share/metainfo rather than share/appdata as discussed in #252 and flatpak/flatpak#4600

Fixes #252

The old path will not be supported by the upcoming AppStream 1.0
release, and the new path is well supported.

Fixes #252
mwleeds added a commit to flatpak/flatpak that referenced this pull request Dec 16, 2021
Read metainfo files from both share/appdata and share/metainfo to
support new and old versions of flatpak-builder
(flatpak/flatpak-builder#441) but only export to
the new path.

Fixes #4599
mwleeds added a commit to flatpak/flatpak that referenced this pull request Dec 17, 2021
Read metainfo files from both share/appdata and share/metainfo to
support new and old versions of flatpak-builder
(flatpak/flatpak-builder#441) but only export to
the new path.

Fixes #4599
alexlarsson pushed a commit to flatpak/flatpak that referenced this pull request Jan 10, 2022
Read metainfo files from both share/appdata and share/metainfo to
support new and old versions of flatpak-builder
(flatpak/flatpak-builder#441) but only export to
the new path.

Fixes #4599
@alexlarsson
Copy link
Member

I merged flatpak/flatpak#4600, so apps installing to appdata will end up being exported to metainfo in the end. It also means that the build installing in metainfo will work, but only with newer (unreleased) versions of flatpak, so at the very least we should not merge this until that is widely available. In fact, I wonder it we need to merge it at all, as the end result will be the same anyway (files in metainfo).

@mwleeds
Copy link
Collaborator Author

mwleeds commented Jan 10, 2022

I guess one reason to merge this eventually is that we want the final name to match the source name as the comment says in builder_manifest_find_appdata_file()

@orowith2os
Copy link

@alexlarsson can you poke at this again? It's been a year and a half since the flatpak PR was merged, and it appears that the relevant Flatpak versions are available such that it can be assumed that the metainfo files are handled properly everywhere.

@AsciiWolf
Copy link
Contributor

Is there any update about this? Flatpak apps on Flathub still seem to have their AppStream metadata exported into the "appdata" directory with *.appdata.xml as their suffix.

@nanonyme
Copy link
Contributor

Is this now obsoleted by libappstream migration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop moving metadata->appdata when all runtimes support metadata
5 participants