Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Support git-lfs #463

Open
2 tasks done
bilelmoussaoui opened this issue Mar 11, 2022 · 2 comments
Open
2 tasks done

[Feature request]: Support git-lfs #463

bilelmoussaoui opened this issue Mar 11, 2022 · 2 comments

Comments

@bilelmoussaoui
Copy link
Member

Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Suggestion

Currently there is no way to tell flatpak-builder to run git-lfs pull on a git repository which requires for now having to use a simple buildsystem and running it yourself

@hhyyrylainen
Copy link

hhyyrylainen commented Nov 11, 2022

Could you share an example of how to do this? When I tried adding a git lfs pull or just a git lfs get my builds fail.
It seems like those commands trigger a checkout that tries to pull from a "file" remote which fails like this:

Filtering content: 100% (33/33), 10.45 MiB | 10.24 MiB/s, done.
Note: switching to '9effbdd957ac78f9c4932d0614277124c01af943'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 9effbdd Added option to specify nuget source to use and writing directly to output folder
Cloning into '/home/hhyyrylainen/Projects/com.revolutionarygamesstudio.ThriveLauncher/.flatpak-builder/build/thrive-launcher-5/RevolutionaryGamesCommon'...
fatal: transport 'file' not allowed
fatal: clone of 'file:///home/hhyyrylainen/Projects/com.revolutionarygamesstudio.ThriveLauncher/.flatpak-builder/git/https_github.com_Revolutionary-Games_RevolutionaryGamesCommon.git' into submodule path '/home/hhyyrylainen/Projects/com.revolutionarygamesstudio.ThriveLauncher/.flatpak-builder/build/thrive-launcher-5/RevolutionaryGamesCommon' failed

Edit: seems like my problem was actually when flatpak-builder was trying to still setup my repo (which seems to cause a LFS content filter anyway, which confused me) it failed to copy over the submodules. So the solution was for me to run the following on my host system:

git config --global --add protocol.file.allow always

And turns out that, that was a bug in flatpak-builder that's not yet fixed in the Fedora repo version (or it might but it's been a couple of days since I last installed updates): #495

@wiiznokes
Copy link

Can i ask where to put the git lfs pull command ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants