Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: Respect "no-parallel-make" with ninja #190

Closed
wants to merge 1 commit into from

Conversation

hadess
Copy link
Contributor

@hadess hadess commented Aug 1, 2018

ninja defaults to running in a highly parallel mode, but some bugs in
meson, such as:
mesonbuild/meson#1994
require building serially.

This change makes the cmake-ninja and meson buildsystems respect
"no-parallel-make" during building.

ninja defaults to running in a highly parallel mode, but some bugs in
meson, such as:
mesonbuild/meson#1994
require building serially.

This change makes the cmake-ninja and meson buildsystems respect
"no-parallel-make" during building.
gnomesysadmins pushed a commit to GNOME/totem that referenced this pull request Aug 1, 2018
Disable vala to work-around:
mesonbuild/meson#1994
until we can use the "-j1" work-around once flatpak-builder is fixed:
flatpak/flatpak-builder#190
@TingPing
Copy link
Member

TingPing commented Aug 1, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link

📌 Commit f40fbe6 has been approved by TingPing

@rh-atomic-bot
Copy link

⚡ Test exempted: pull fully rebased and already tested.

@alexlarsson alexlarsson deleted the wip/hadess/ninja-respect-no-parallel-build branch May 6, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants